diff options
| author | Adam Johnson <me@adamj.eu> | 2025-09-05 13:41:48 +0100 |
|---|---|---|
| committer | Jacob Walls <jacobtylerwalls@gmail.com> | 2026-05-11 12:32:30 -0400 |
| commit | 5ef47fccfafcbf540f870c2ee86c122cfd43a89b (patch) | |
| tree | 9a5974e5cc4d98bc69c0c41f0e342a7702f56fb2 /tests/proxy_models | |
| parent | 0c634de4e6950ec6fb83ab420b4af9c645b28acd (diff) | |
Refs #36593 -- Used explicit select_related() calls in tests.
This commit prepares for the deprecation of select_related() without arguments
by updating tests that used select_related() as a shorthand to explicitly
specify the related fields to be selected.
Diffstat (limited to 'tests/proxy_models')
| -rw-r--r-- | tests/proxy_models/tests.py | 18 |
1 files changed, 11 insertions, 7 deletions
diff --git a/tests/proxy_models/tests.py b/tests/proxy_models/tests.py index 98bba949f5..e7d4ec714f 100644 --- a/tests/proxy_models/tests.py +++ b/tests/proxy_models/tests.py @@ -320,17 +320,17 @@ class ProxyModelTests(TestCase): country = Country.objects.create(name="Australia") State.objects.create(name="New South Wales", country=country) - resp = [s.name for s in State.objects.select_related()] + resp = [s.name for s in State.objects.select_related("country")] self.assertEqual(resp, ["New South Wales"]) - resp = [s.name for s in StateProxy.objects.select_related()] + resp = [s.name for s in StateProxy.objects.select_related("country")] self.assertEqual(resp, ["New South Wales"]) self.assertEqual( StateProxy.objects.get(name="New South Wales").name, "New South Wales" ) - resp = StateProxy.objects.select_related().get(name="New South Wales") + resp = StateProxy.objects.select_related("country").get(name="New South Wales") self.assertEqual(resp.name, "New South Wales") def test_filter_proxy_relation_reverse(self): @@ -369,15 +369,19 @@ class ProxyModelTests(TestCase): self.assertEqual(repr(resp), "<ProxyBug: ProxyBug:fix this>") # Select related + filter on proxy - resp = ProxyBug.objects.select_related().get(version__icontains="beta") + resp = ProxyBug.objects.select_related("reporter").get( + version__icontains="beta" + ) self.assertEqual(repr(resp), "<ProxyBug: ProxyBug:fix this>") # Proxy of proxy, select_related + filter - resp = ProxyProxyBug.objects.select_related().get(version__icontains="beta") + resp = ProxyProxyBug.objects.select_related("reporter").get( + version__icontains="beta" + ) self.assertEqual(repr(resp), "<ProxyProxyBug: ProxyProxyBug:fix this>") # Select related + filter on a related proxy field - resp = ProxyImprovement.objects.select_related().get( + resp = ProxyImprovement.objects.select_related("reporter").get( reporter__name__icontains="butor" ) self.assertEqual( @@ -385,7 +389,7 @@ class ProxyModelTests(TestCase): ) # Select related + filter on a related proxy of proxy field - resp = ProxyImprovement.objects.select_related().get( + resp = ProxyImprovement.objects.select_related("associated_bug").get( associated_bug__summary__icontains="fix" ) self.assertEqual( |
