From 5ef47fccfafcbf540f870c2ee86c122cfd43a89b Mon Sep 17 00:00:00 2001 From: Adam Johnson Date: Fri, 5 Sep 2025 13:41:48 +0100 Subject: Refs #36593 -- Used explicit select_related() calls in tests. This commit prepares for the deprecation of select_related() without arguments by updating tests that used select_related() as a shorthand to explicitly specify the related fields to be selected. --- tests/proxy_models/tests.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) (limited to 'tests/proxy_models') diff --git a/tests/proxy_models/tests.py b/tests/proxy_models/tests.py index 98bba949f5..e7d4ec714f 100644 --- a/tests/proxy_models/tests.py +++ b/tests/proxy_models/tests.py @@ -320,17 +320,17 @@ class ProxyModelTests(TestCase): country = Country.objects.create(name="Australia") State.objects.create(name="New South Wales", country=country) - resp = [s.name for s in State.objects.select_related()] + resp = [s.name for s in State.objects.select_related("country")] self.assertEqual(resp, ["New South Wales"]) - resp = [s.name for s in StateProxy.objects.select_related()] + resp = [s.name for s in StateProxy.objects.select_related("country")] self.assertEqual(resp, ["New South Wales"]) self.assertEqual( StateProxy.objects.get(name="New South Wales").name, "New South Wales" ) - resp = StateProxy.objects.select_related().get(name="New South Wales") + resp = StateProxy.objects.select_related("country").get(name="New South Wales") self.assertEqual(resp.name, "New South Wales") def test_filter_proxy_relation_reverse(self): @@ -369,15 +369,19 @@ class ProxyModelTests(TestCase): self.assertEqual(repr(resp), "") # Select related + filter on proxy - resp = ProxyBug.objects.select_related().get(version__icontains="beta") + resp = ProxyBug.objects.select_related("reporter").get( + version__icontains="beta" + ) self.assertEqual(repr(resp), "") # Proxy of proxy, select_related + filter - resp = ProxyProxyBug.objects.select_related().get(version__icontains="beta") + resp = ProxyProxyBug.objects.select_related("reporter").get( + version__icontains="beta" + ) self.assertEqual(repr(resp), "") # Select related + filter on a related proxy field - resp = ProxyImprovement.objects.select_related().get( + resp = ProxyImprovement.objects.select_related("reporter").get( reporter__name__icontains="butor" ) self.assertEqual( @@ -385,7 +389,7 @@ class ProxyModelTests(TestCase): ) # Select related + filter on a related proxy of proxy field - resp = ProxyImprovement.objects.select_related().get( + resp = ProxyImprovement.objects.select_related("associated_bug").get( associated_bug__summary__icontains="fix" ) self.assertEqual( -- cgit v1.3