summaryrefslogtreecommitdiff
path: root/tests/forms_tests
diff options
context:
space:
mode:
authorDavid Smith <smithdc@gmail.com>2021-11-05 08:11:25 +0000
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2021-11-05 11:05:52 +0100
commitc6c6cd3c5ad9c36795bb120e521590424f034ae4 (patch)
tree54e6978fbd2533013a9e6053b9e936b124b63cf2 /tests/forms_tests
parent2c01ebb4be5d53cbf6450f356c10e436025d6d07 (diff)
Fixed #33235 -- Removed "for = ..." from MultiWidget's <label>.
This improves accessibility for screen reader users.
Diffstat (limited to 'tests/forms_tests')
-rw-r--r--tests/forms_tests/field_tests/test_multivaluefield.py4
-rw-r--r--tests/forms_tests/field_tests/test_splitdatetimefield.py15
2 files changed, 16 insertions, 3 deletions
diff --git a/tests/forms_tests/field_tests/test_multivaluefield.py b/tests/forms_tests/field_tests/test_multivaluefield.py
index 22e0892f68..449bf16d19 100644
--- a/tests/forms_tests/field_tests/test_multivaluefield.py
+++ b/tests/forms_tests/field_tests/test_multivaluefield.py
@@ -141,7 +141,7 @@ class MultiValueFieldTest(SimpleTestCase):
self.assertHTMLEqual(
form.as_table(),
"""
- <tr><th><label for="id_field1_0">Field1:</label></th>
+ <tr><th><label>Field1:</label></th>
<td><input type="text" name="field1_0" id="id_field1_0" required>
<select multiple name="field1_1" id="id_field1_1" required>
<option value="J">John</option>
@@ -164,7 +164,7 @@ class MultiValueFieldTest(SimpleTestCase):
self.assertHTMLEqual(
form.as_table(),
"""
- <tr><th><label for="id_field1_0">Field1:</label></th>
+ <tr><th><label>Field1:</label></th>
<td><input type="text" name="field1_0" value="some text" id="id_field1_0" required>
<select multiple name="field1_1" id="id_field1_1" required>
<option value="J" selected>John</option>
diff --git a/tests/forms_tests/field_tests/test_splitdatetimefield.py b/tests/forms_tests/field_tests/test_splitdatetimefield.py
index 716e49c343..bf20587682 100644
--- a/tests/forms_tests/field_tests/test_splitdatetimefield.py
+++ b/tests/forms_tests/field_tests/test_splitdatetimefield.py
@@ -1,7 +1,7 @@
import datetime
from django.core.exceptions import ValidationError
-from django.forms import SplitDateTimeField
+from django.forms import Form, SplitDateTimeField
from django.forms.widgets import SplitDateTimeWidget
from django.test import SimpleTestCase
@@ -60,3 +60,16 @@ class SplitDateTimeFieldTest(SimpleTestCase):
self.assertTrue(f.has_changed(datetime.datetime(2008, 5, 6, 12, 40, 00), ['2008-05-06', '12:40:00']))
self.assertFalse(f.has_changed(datetime.datetime(2008, 5, 6, 12, 40, 00), ['06/05/2008', '12:40']))
self.assertTrue(f.has_changed(datetime.datetime(2008, 5, 6, 12, 40, 00), ['06/05/2008', '12:41']))
+
+ def test_form_as_table(self):
+ class TestForm(Form):
+ datetime = SplitDateTimeField()
+
+ f = TestForm()
+ self.assertHTMLEqual(
+ f.as_table(),
+ '<tr><th><label>Datetime:</label></th><td>'
+ '<input type="text" name="datetime_0" required id="id_datetime_0">'
+ '<input type="text" name="datetime_1" required id="id_datetime_1">'
+ '</td></tr>',
+ )