diff options
| author | Nick Pope <nick.pope@flightdataservices.com> | 2019-10-21 09:55:05 +0100 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2019-10-29 12:37:30 +0100 |
| commit | 7552de7866dcd270a0f353b007b4aceaa7f3ff3e (patch) | |
| tree | 2e84292833853d9659671ed304cb32d5acef5f90 /tests/forms_tests | |
| parent | a6cb8ec3895a72bfb7f8e62d4b05dd5de6b738af (diff) | |
Used more specific unittest assertions in tests.
* assertIsNone()/assertIsNotNone() instead of comparing to None.
* assertLess() for < comparisons.
* assertIs() for 'is' expressions.
* assertIsInstance() for isinstance() expressions.
* rounding of assertAlmostEqual() for round() expressions.
* assertIs(..., True/False) instead of comparing to True/False.
* assertIs()/assertIsNot() for ==/!= comparisons.
* assertNotEqual() for == comparisons.
* assertTrue()/assertFalse() instead of comparing to True/False.
Diffstat (limited to 'tests/forms_tests')
| -rw-r--r-- | tests/forms_tests/tests/test_forms.py | 4 | ||||
| -rw-r--r-- | tests/forms_tests/widget_tests/test_select.py | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/tests/forms_tests/tests/test_forms.py b/tests/forms_tests/tests/test_forms.py index 269567dac8..552f3b866c 100644 --- a/tests/forms_tests/tests/test_forms.py +++ b/tests/forms_tests/tests/test_forms.py @@ -1973,7 +1973,7 @@ Password: <input type="password" name="password" required></li> occupation = CharField(initial=lambda: 'Unknown') form = PersonForm(initial={'first_name': 'Jane'}) - self.assertEqual(form.get_initial_for_field(form.fields['age'], 'age'), None) + self.assertIsNone(form.get_initial_for_field(form.fields['age'], 'age')) self.assertEqual(form.get_initial_for_field(form.fields['last_name'], 'last_name'), 'Doe') # Form.initial overrides Field.initial. self.assertEqual(form.get_initial_for_field(form.fields['first_name'], 'first_name'), 'Jane') @@ -3729,7 +3729,7 @@ class RendererTests(SimpleTestCase): default_renderer = CustomRenderer form = CustomForm() - self.assertTrue(isinstance(form.renderer, CustomForm.default_renderer)) + self.assertIsInstance(form.renderer, CustomForm.default_renderer) def test_attribute_override(self): class CustomForm(Form): diff --git a/tests/forms_tests/widget_tests/test_select.py b/tests/forms_tests/widget_tests/test_select.py index fd4c1fb34c..935f6f6b5e 100644 --- a/tests/forms_tests/widget_tests/test_select.py +++ b/tests/forms_tests/widget_tests/test_select.py @@ -257,13 +257,13 @@ class SelectTest(WidgetTest): self.assertEqual(options[0]['value'], 'J') self.assertEqual(options[0]['label'], 'John') self.assertEqual(options[0]['index'], '0') - self.assertEqual(options[0]['selected'], True) + self.assertIs(options[0]['selected'], True) # Template-related attributes self.assertEqual(options[1]['name'], 'name') self.assertEqual(options[1]['value'], 'P') self.assertEqual(options[1]['label'], 'Paul') self.assertEqual(options[1]['index'], '1') - self.assertEqual(options[1]['selected'], False) + self.assertIs(options[1]['selected'], False) def test_optgroups(self): choices = [ @@ -336,7 +336,7 @@ class SelectTest(WidgetTest): ) self.assertEqual(index, 1) label, options, index = unknown - self.assertEqual(label, None) + self.assertIsNone(label) self.assertEqual( options, [{ |