diff options
| author | Jon Dufresne <jon.dufresne@gmail.com> | 2016-06-16 11:19:18 -0700 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2016-06-16 14:21:14 -0400 |
| commit | 13d60298ea2a07242dc3952a9dfcd9c8857bf1f9 (patch) | |
| tree | 230d0f843401781e9b2062fe3c1f929655a5527e /tests/forms_tests | |
| parent | 70b7d6b4ea0cbd67406d193f0a7fed7e290d1eb6 (diff) | |
[1.10.x] Fixed #26747 -- Used more specific assertions in the Django test suite.
Backport of 4f336f66523001b009ab038b10848508fd208b3b from master
Diffstat (limited to 'tests/forms_tests')
5 files changed, 19 insertions, 19 deletions
diff --git a/tests/forms_tests/field_tests/test_booleanfield.py b/tests/forms_tests/field_tests/test_booleanfield.py index 0fa5357ae3..e267777b94 100644 --- a/tests/forms_tests/field_tests/test_booleanfield.py +++ b/tests/forms_tests/field_tests/test_booleanfield.py @@ -27,18 +27,18 @@ class BooleanFieldTest(SimpleTestCase): def test_booleanfield_clean_2(self): f = BooleanField(required=False) - self.assertEqual(False, f.clean('')) - self.assertEqual(False, f.clean(None)) - self.assertEqual(True, f.clean(True)) - self.assertEqual(False, f.clean(False)) - self.assertEqual(True, f.clean(1)) - self.assertEqual(False, f.clean(0)) - self.assertEqual(True, f.clean('1')) - self.assertEqual(False, f.clean('0')) - self.assertEqual(True, f.clean('Django rocks')) - self.assertEqual(False, f.clean('False')) - self.assertEqual(False, f.clean('false')) - self.assertEqual(False, f.clean('FaLsE')) + self.assertIs(f.clean(''), False) + self.assertIs(f.clean(None), False) + self.assertIs(f.clean(True), True) + self.assertIs(f.clean(False), False) + self.assertIs(f.clean(1), True) + self.assertIs(f.clean(0), False) + self.assertIs(f.clean('1'), True) + self.assertIs(f.clean('0'), False) + self.assertIs(f.clean('Django rocks'), True) + self.assertIs(f.clean('False'), False) + self.assertIs(f.clean('false'), False) + self.assertIs(f.clean('FaLsE'), False) def test_boolean_picklable(self): self.assertIsInstance(pickle.loads(pickle.dumps(BooleanField())), BooleanField) diff --git a/tests/forms_tests/field_tests/test_uuidfield.py b/tests/forms_tests/field_tests/test_uuidfield.py index 05a3f0d869..fe432e0725 100644 --- a/tests/forms_tests/field_tests/test_uuidfield.py +++ b/tests/forms_tests/field_tests/test_uuidfield.py @@ -16,7 +16,7 @@ class UUIDFieldTest(SimpleTestCase): def test_uuidfield_2(self): field = UUIDField(required=False) value = field.clean('') - self.assertEqual(value, None) + self.assertIsNone(value) def test_uuidfield_3(self): field = UUIDField() diff --git a/tests/forms_tests/tests/test_forms.py b/tests/forms_tests/tests/test_forms.py index 4309fb3d86..89d8d6bb67 100644 --- a/tests/forms_tests/tests/test_forms.py +++ b/tests/forms_tests/tests/test_forms.py @@ -323,7 +323,7 @@ class FormsTestCase(SimpleTestCase): data = {'first_name': 'John', 'last_name': 'Lennon'} f = OptionalPersonForm(data) self.assertTrue(f.is_valid()) - self.assertEqual(f.cleaned_data['birth_date'], None) + self.assertIsNone(f.cleaned_data['birth_date']) self.assertEqual(f.cleaned_data['first_name'], 'John') self.assertEqual(f.cleaned_data['last_name'], 'Lennon') @@ -1926,10 +1926,10 @@ Password: <input type="password" name="password" required /></li> unbound = UserRegistration() bound = UserRegistration({'password': 'foo'}) - self.assertEqual(bound['username'].value(), None) + self.assertIsNone(bound['username'].value()) self.assertEqual(unbound['username'].value(), 'djangonaut') self.assertEqual(bound['password'].value(), 'foo') - self.assertEqual(unbound['password'].value(), None) + self.assertIsNone(unbound['password'].value()) def test_boundfield_initial_called_once(self): """ @@ -3089,7 +3089,7 @@ Good luck picking a username that doesn't already exist.</p> raise ValidationError('Non-field error.', code='secret', params={'a': 1, 'b': 2}) form = MyForm({}) - self.assertEqual(form.is_valid(), False) + self.assertIs(form.is_valid(), False) errors = form.errors.as_text() control = [ diff --git a/tests/forms_tests/widget_tests/test_checkboxinput.py b/tests/forms_tests/widget_tests/test_checkboxinput.py index 45d8191f75..77b03b9ea9 100644 --- a/tests/forms_tests/widget_tests/test_checkboxinput.py +++ b/tests/forms_tests/widget_tests/test_checkboxinput.py @@ -84,4 +84,4 @@ class CheckboxInputTest(WidgetTest): def test_value_from_datadict_string_int(self): value = self.widget.value_from_datadict({'testing': '0'}, {}, 'testing') - self.assertEqual(value, True) + self.assertIs(value, True) diff --git a/tests/forms_tests/widget_tests/test_clearablefileinput.py b/tests/forms_tests/widget_tests/test_clearablefileinput.py index 46bad58f3a..720f17b035 100644 --- a/tests/forms_tests/widget_tests/test_clearablefileinput.py +++ b/tests/forms_tests/widget_tests/test_clearablefileinput.py @@ -87,7 +87,7 @@ class ClearableFileInputTest(WidgetTest): files={}, name='myfile', ) - self.assertEqual(value, False) + self.assertIs(value, False) def test_clear_input_checked_returns_false_only_if_not_required(self): """ |
