summaryrefslogtreecommitdiff
path: root/docs
diff options
context:
space:
mode:
authorErik Romijn <eromijn@solidlinks.nl>2013-02-24 13:20:41 +0100
committerErik Romijn <eromijn@solidlinks.nl>2013-02-24 13:58:38 +0100
commitade992c61e15fbc83d87bfc688c0f844b6ef19fd (patch)
tree896a14f588761de03761b1bfe5abba9b2595ced8 /docs
parente4ee3d8fcac987bc91ab9c559f39f52949227b76 (diff)
Fixed #16302 -- Ensure contrib.comments is IPv6 capable
Changed the ip_address field for Comment to GenericIPAddressField. Added instructions to the release notes on how to update the schema of existing databases.
Diffstat (limited to 'docs')
-rw-r--r--docs/releases/1.6.txt24
1 files changed, 24 insertions, 0 deletions
diff --git a/docs/releases/1.6.txt b/docs/releases/1.6.txt
index ce1e643946..497a0349db 100644
--- a/docs/releases/1.6.txt
+++ b/docs/releases/1.6.txt
@@ -149,6 +149,30 @@ Backwards incompatible changes in 1.6
{{ title }}{# Translators: Extracted and associated with 'Welcome' below #}
<h1>{% trans "Welcome" %}</h1>
+* The :doc:`comments </ref/contrib/comments/index>` app now uses a ``GenericIPAddressField``
+ for storing commenters' IP addresses, to support comments submitted from IPv6 addresses.
+ Until now, it stored them in an ``IPAddressField``, which is only meant to support IPv4.
+ When saving a comment made from an IPv6 address, the address would be silently truncated
+ on MySQL databases, and raise an exception on Oracle.
+ You will need to change the column type in your database to benefit from this change.
+
+ For MySQL, execute this query on your project's database:
+
+ .. code-block:: sql
+
+ ALTER TABLE django_comments MODIFY ip_address VARCHAR(39);
+
+ For Oracle, execute this query:
+
+ .. code-block:: sql
+
+ ALTER TABLE DJANGO_COMMENTS MODIFY (ip_address VARCHAR2(39));
+
+ If you do not apply this change, the behaviour is unchanged: on MySQL, IPv6 addresses
+ are silently truncated; on Oracle, an exception is generated. No database
+ change is needed for SQLite or PostgreSQL databases.
+
+
.. warning::
In addition to the changes outlined in this section, be sure to review the