summaryrefslogtreecommitdiff
path: root/docs/ref
diff options
context:
space:
mode:
authorSimon Charette <charette.s@gmail.com>2023-11-23 00:09:08 -0500
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2023-11-23 06:10:24 +0100
commitcf95de9d24c987beff51b54979c02aeef1f98050 (patch)
tree624baa0e4af139eb31a06f7bebfc4e2334007044 /docs/ref
parent6d7313bc870b0a37287dc7e3b30b1b5583c9ef0e (diff)
[4.2.x] Fixed #34987 -- Fixed queryset crash when mixing aggregate and window annotations.
Regression in f387d024fc75569d2a4a338bfda76cc2f328f627. Just like `OrderByList` the `ExpressionList` expression used to wrap `Window.partition_by` must implement `get_group_by_cols` to ensure the necessary grouping when mixing window expressions with aggregate annotations is performed against the partition members and not the partition expression itself. This is necessary because while `partition_by` is implemented as a source expression of `Window` it's actually a fragment of the WINDOW expression at the SQL level and thus it should result in a group by its members and not the sum of them. Thanks ElRoberto538 for the report. Backport of e76cc93b0168fa3abbafb9af1ab4535814b751f0 from main
Diffstat (limited to 'docs/ref')
0 files changed, 0 insertions, 0 deletions