summaryrefslogtreecommitdiff
path: root/docs/ref
diff options
context:
space:
mode:
authorTomer Chachamu <tomer.chachamu@gmail.com>2017-06-20 19:02:43 +0100
committerTim Graham <timograham@gmail.com>2017-07-18 08:48:25 -0400
commit62917cee5ac75693aa5d9a3de5d8935da2f011df (patch)
tree3deacbc0b636f94a4da51681afd3a6d89589ca9c /docs/ref
parent12812f6b2ddd38fba2ecb277199f4ea5aecca1ff (diff)
Doc'd the need to remove default ordering on Subquery aggregates.
Diffstat (limited to 'docs/ref')
-rw-r--r--docs/ref/models/expressions.txt11
1 files changed, 6 insertions, 5 deletions
diff --git a/docs/ref/models/expressions.txt b/docs/ref/models/expressions.txt
index f5140f5df5..46dd5ecdd3 100644
--- a/docs/ref/models/expressions.txt
+++ b/docs/ref/models/expressions.txt
@@ -601,15 +601,16 @@ Assuming both models have a ``length`` field, to find posts where the post
length is greater than the total length of all combined comments::
>>> from django.db.models import OuterRef, Subquery, Sum
- >>> comments = Comment.objects.filter(post=OuterRef('pk')).values('post')
+ >>> comments = Comment.objects.filter(post=OuterRef('pk')).order_by().values('post')
>>> total_comments = comments.annotate(total=Sum('length')).values('total')
>>> Post.objects.filter(length__gt=Subquery(total_comments))
The initial ``filter(...)`` limits the subquery to the relevant parameters.
-``values('post')`` aggregates comments by ``Post``. Finally, ``annotate(...)``
-performs the aggregation. The order in which these queryset methods are applied
-is important. In this case, since the subquery must be limited to a single
-column, ``values('total')`` is required.
+``order_by()`` removes the default :attr:`~django.db.models.Options.ordering`
+(if any) on the ``Comment`` model. ``values('post')`` aggregates comments by
+``Post``. Finally, ``annotate(...)`` performs the aggregation. The order in
+which these queryset methods are applied is important. In this case, since the
+subquery must be limited to a single column, ``values('total')`` is required.
This is the only way to perform an aggregation within a ``Subquery``, as
using :meth:`~.QuerySet.aggregate` attempts to evaluate the queryset (and if