diff options
| author | Keryn Knight <keryn@kerynknight.com> | 2021-07-20 07:10:52 +0200 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2021-07-20 07:19:28 +0200 |
| commit | ff661dbd506efbdf51cc8da89cb98731c8a62f49 (patch) | |
| tree | d825d121c7b2349f4c2674d7ef584db7ae05a691 /docs/make.bat | |
| parent | fb35e0a2feb36e60b93a12dd43eb9eed2015adda (diff) | |
Refs #32940 -- Removed unnecessary branch in Node.add().
The "data in self.children" branch was causing data.__eq__ to be
called for each entries in "self.children" which resulted in a huge
slowdown during queryset construction.
It's purpose was to prevent queries of the form
Model.objects.filter(foo='bar').filter(foo='bar')
from resulting in
WHERE foo='bar' AND foo='bar'
but it's not covered by the suite and has arguable performance benefits
since it's not very common and SQL engines are usually very good at
folding/optimizing these.
See also #32632 for prior discussion around comparing data to the
Node's children.
Co-authored-by: Nick Pope <nick@nickpope.me.uk>
Diffstat (limited to 'docs/make.bat')
0 files changed, 0 insertions, 0 deletions
