diff options
| author | Carlton Gibson <carlton.gibson@noumenal.es> | 2021-04-14 20:23:21 +0200 |
|---|---|---|
| committer | Carlton Gibson <carlton@noumenal.es> | 2021-04-15 17:14:22 +0200 |
| commit | e3e2276e6fe6fd77e4fbdeeb2a287288d31de3bb (patch) | |
| tree | acfb5287b125a65ea05c1b4d228ddd92fa154019 /docs/internals | |
| parent | a815a6a3159d5f708866ca968e8994f201ea3e43 (diff) | |
Fixed #32652 -- Fixed links to new contributors FAQ.
Diffstat (limited to 'docs/internals')
| -rw-r--r-- | docs/internals/contributing/new-contributors.txt | 29 | ||||
| -rw-r--r-- | docs/internals/contributing/triaging-tickets.txt | 8 |
2 files changed, 17 insertions, 20 deletions
diff --git a/docs/internals/contributing/new-contributors.txt b/docs/internals/contributing/new-contributors.txt index 29502cc782..8457f41941 100644 --- a/docs/internals/contributing/new-contributors.txt +++ b/docs/internals/contributing/new-contributors.txt @@ -138,25 +138,20 @@ some advice to make your work on Django more useful and rewarding. writing the very first tests for that feature, not that you get a pass from writing tests altogether. -.. _easy pickings: https://code.djangoproject.com/query?status=!closed&easy=1 - -.. _new-contributors-faq: +* **Be patient** -FAQ -=== + It's not always easy for your ticket or your patch to be reviewed quickly. + This isn't personal. There are a lot of tickets and pull requests to get + through. -1. **This ticket I care about has been ignored for days/weeks/months! What can - I do to get it committed?** + Keeping your patch up to date is important. Review the ticket on Trac to + ensure that the *Needs tests*, *Needs documentation*, and *Patch needs + improvement* flags are unchecked once you've addressed all review comments. - First off, it's not personal. Django is entirely developed by volunteers - (except the Django fellow), and sometimes folks just don't have time. The - best thing to do is to send a gentle reminder to the |django-developers| - mailing list asking for review on the ticket, or to bring it up in the - ``#django-dev`` IRC channel. + Remember that Django has an 8 month release cycle, so there's plenty of time + for your patch to be reviewed. -2. **I'm sure my ticket is absolutely 100% perfect, can I mark it as RFC - myself?** + Finally, a well-timed reminder can help. See :ref:`contributing code FAQ + <new-contributors-faq>` for ideas here. - Short answer: No. It's always better to get another set of eyes on a - ticket. If you're having trouble getting that second set of eyes, see - question 1, above. +.. _easy pickings: https://code.djangoproject.com/query?status=!closed&easy=1 diff --git a/docs/internals/contributing/triaging-tickets.txt b/docs/internals/contributing/triaging-tickets.txt index 8341ee0e3c..3bd02044d3 100644 --- a/docs/internals/contributing/triaging-tickets.txt +++ b/docs/internals/contributing/triaging-tickets.txt @@ -143,9 +143,11 @@ Ready For Checkin The ticket was reviewed by any member of the community other than the person who supplied the patch and found to meet all the requirements for a commit-ready patch. A committer now needs to give the patch a final -review prior to being committed. See the -:ref:`New contributors' FAQ<new-contributors-faq>` for "My ticket has been in -RFC forever! What should I do?" +review prior to being committed. + +There are a lot of pull requests. It can take a while for your patch to get +reviewed. See the :ref:`contributing code FAQ<new-contributors-faq>` for some +ideas here. Someday/Maybe ------------- |
