diff options
| author | Tim Graham <timograham@gmail.com> | 2016-11-25 14:03:11 -0500 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2016-12-21 20:18:13 -0500 |
| commit | 61225ef721c0bace87be8f80677e575ad58d8ff7 (patch) | |
| tree | f05a844f23c280ef7f0fc3c7113cea961884fd43 /docs/internals/contributing/writing-code | |
| parent | 96271533d2d245d78b90e29b6f8dbef0876ac9b5 (diff) | |
Removed the importance of "core developers" in triaging tickets, etc.
Diffstat (limited to 'docs/internals/contributing/writing-code')
| -rw-r--r-- | docs/internals/contributing/writing-code/submitting-patches.txt | 7 | ||||
| -rw-r--r-- | docs/internals/contributing/writing-code/working-with-git.txt | 2 |
2 files changed, 4 insertions, 5 deletions
diff --git a/docs/internals/contributing/writing-code/submitting-patches.txt b/docs/internals/contributing/writing-code/submitting-patches.txt index ce1d6403a8..cbda36075d 100644 --- a/docs/internals/contributing/writing-code/submitting-patches.txt +++ b/docs/internals/contributing/writing-code/submitting-patches.txt @@ -249,9 +249,9 @@ the "Triage Stage" on the corresponding Trac ticket to "Ready for checkin". If you've left comments for improvement on the pull request, please tick the appropriate flags on the Trac ticket based on the results of your review: "Patch needs improvement", "Needs documentation", and/or "Needs tests". As time -and interest permits, core developers do final reviews of "Ready for checkin" +and interest permits, committers do final reviews of "Ready for checkin" tickets and will either commit the patch or bump it back to "Accepted" if -further works need to be done. If you're looking to become a core developer, +further works need to be done. If you're looking to become a committer, doing thorough reviews of patches is a great way to earn trust. Looking for a patch to review? Check out the "Patches needing review" section @@ -296,8 +296,7 @@ All code changes guidelines? Are there any ``flake8`` errors? * If the change is backwards incompatible in any way, is there a note in the release notes (``docs/releases/A.B.txt``)? -* Is Django's test suite passing? Ask in ``#django-dev`` for a core dev - to build the pull request against our continuous integration server. +* Is Django's test suite passing? All tickets ----------- diff --git a/docs/internals/contributing/writing-code/working-with-git.txt b/docs/internals/contributing/writing-code/working-with-git.txt index 7cea064b2a..85ca6dfc85 100644 --- a/docs/internals/contributing/writing-code/working-with-git.txt +++ b/docs/internals/contributing/writing-code/working-with-git.txt @@ -3,7 +3,7 @@ Working with Git and GitHub =========================== This section explains how the community can contribute code to Django via pull -requests. If you're interested in how core developers handle them, see +requests. If you're interested in how committers handle them, see :doc:`../committing-code`. Below, we are going to show how to create a GitHub pull request containing the |