diff options
| author | Malcolm Tredinnick <malcolm.tredinnick@gmail.com> | 2011-08-26 05:28:58 +0000 |
|---|---|---|
| committer | Malcolm Tredinnick <malcolm.tredinnick@gmail.com> | 2011-08-26 05:28:58 +0000 |
| commit | 499f01842eac1d1248fbf60df94444c08282ef3a (patch) | |
| tree | 4ef41b9abd0f28fdcf79956a91f66e18115ee7c5 /docs/internals/contributing/writing-code | |
| parent | 3e65f9633ba86d9c615556f45034301f880bca10 (diff) | |
Add a note about discouraging whitespace- or formatting-only patches.
We follow the python-dev path here. Deliberately.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16691 bcc190cf-cafb-0310-a4f2-bffc1f526a37
Diffstat (limited to 'docs/internals/contributing/writing-code')
| -rw-r--r-- | docs/internals/contributing/writing-code/coding-style.txt | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/docs/internals/contributing/writing-code/coding-style.txt b/docs/internals/contributing/writing-code/coding-style.txt index 34eef100c7..1394c1e6a0 100644 --- a/docs/internals/contributing/writing-code/coding-style.txt +++ b/docs/internals/contributing/writing-code/coding-style.txt @@ -188,7 +188,10 @@ Miscellaneous add unnecessary bytes, add visual clutter to the patches and can also occasionally cause unnecessary merge conflicts. Some IDE's can be configured to automatically remove them and most VCS tools can be set to - highlight them in diff outputs. + highlight them in diff outputs. Note, however, that patches which only + remove whitespace (or only make changes for nominal PEP 8 conformance) + are likely to be rejected, since they only introduce noise rather than + code improvement. Tidy up when you're next changing code in the area. * Please don't put your name in the code you contribute. Our policy is to keep contributors' names in the ``AUTHORS`` file distributed with Django |