diff options
| author | Nick Pope <nick@nickpope.me.uk> | 2021-02-08 12:02:58 +0000 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2021-04-28 21:19:42 +0200 |
| commit | 0c71e0f9cfa714a22297ad31dd5613ee548db379 (patch) | |
| tree | d9f7d4abfb5382418cc5104a8233f8bc67a7c499 /docs/internals/contributing/writing-code/javascript.txt | |
| parent | a6c79f4987c020cc9e96d4c5fc47730cd1031b4c (diff) | |
Removed unnecessary reuse_with_filtered_relation argument from Query methods.
In Query.join() the argument reuse_with_filtered_relation was used to
determine whether to use == or .equals(). As this area of code is
related to aliases, we only expect an instance of Join or BaseTable to
be provided - the only two classes that provide .equals().
In both cases, the implementations of __eq__() and equals() are based
on use of the "identity" property. __eq__() performs an isinstance()
check first, returning NotImplemented if required. BaseTable.equals()
then does a straightforward equality check on "identity". Join.equals()
is a little bit different as it skips checking the last element of the
"identity" property: filtered_relation. This was only included
previously when the with_filtered_relation argument was True, impossible
since bbf141bcdc31f1324048af9233583a523ac54c94.
Diffstat (limited to 'docs/internals/contributing/writing-code/javascript.txt')
0 files changed, 0 insertions, 0 deletions
