diff options
| author | Tim Graham <timograham@gmail.com> | 2018-11-17 18:50:26 -0500 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2018-11-17 19:27:53 -0500 |
| commit | 9cac10eee49eae3bbf7bd133ba0ae931b275324c (patch) | |
| tree | ff643109e069cae9e4583b334fe6c29191150ef2 /django | |
| parent | e62f6e0968eb19a44198211b5398c5738db454c5 (diff) | |
Added BaseDatabaseSchemaEditor._effective_default() to allow testing without a connection.
Diffstat (limited to 'django')
| -rw-r--r-- | django/db/backends/base/schema.py | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/django/db/backends/base/schema.py b/django/db/backends/base/schema.py index 813c5bbd75..68250c895e 100644 --- a/django/db/backends/base/schema.py +++ b/django/db/backends/base/schema.py @@ -199,8 +199,9 @@ class BaseDatabaseSchemaEditor: 'requires_literal_defaults must provide a prepare_default() method' ) - def effective_default(self, field): - """Return a field's effective database default value.""" + @classmethod + def _effective_default(self, field): + # This method allows testing its logic without a connection. if field.has_default(): default = field.get_default() elif not field.null and field.blank and field.empty_strings_allowed: @@ -219,8 +220,11 @@ class BaseDatabaseSchemaEditor: default = timezone.now() else: default = None - # Convert the value so it can be sent to the database. - return field.get_db_prep_save(default, self.connection) + return default + + def effective_default(self, field): + """Return a field's effective database default value.""" + return field.get_db_prep_save(self._effective_default(field), self.connection) def quote_value(self, value): """ |
