[4.2.x] Fixed #34798 -- Fixed QuerySet.aggregate() crash when referencing expressions containing subqueries.

Regression in 59bea9efd2768102fc9d3aedda469502c218e9b7,
complements e5c844d6f2a4ac6ae674d741b5f1fa2a688cedf4.

Refs #28477, #34551.

Thanks Haldun Komsuoglu for the report.

Backport of 3b4a571275d967512866012955eb0b3ae486d63c from main

2 files changed, 8 insertions, 1 deletions

diff --git a/django/db/models/expressions.py b/django/db/models/expressions.py
index cc78ac8773..0847eb0931 100644
--- a/django/db/models/expressions.py
+++ b/django/db/models/expressions.py
@@ -255,6 +255,13 @@ class BaseExpression:
             for expr in self.get_source_expressions()
         )
 
+    @cached_property
+    def contains_subquery(self):
+        return any(
+            expr and (getattr(expr, "subquery", False) or expr.contains_subquery)
+            for expr in self.get_source_expressions()
+        )
+
     def resolve_expression(
         self, query=None, allow_joins=True, reuse=None, summarize=False, for_save=False
     ):
diff --git a/django/db/models/sql/query.py b/django/db/models/sql/query.py
index 27f94175bb..0709c4a45f 100644
--- a/django/db/models/sql/query.py
+++ b/django/db/models/sql/query.py
@@ -404,7 +404,7 @@ class Query(BaseExpression):
             # members of `aggregates` to resolve against each others.
             self.append_annotation_mask([alias])
             refs_subquery |= any(
-                getattr(self.annotations[ref], "subquery", False)
+                getattr(self.annotations[ref], "contains_subquery", False)
                 for ref in aggregate.get_refs()
             )
             refs_window |= any(