summaryrefslogtreecommitdiff
path: root/django
diff options
context:
space:
mode:
authorMalcolm Tredinnick <malcolm.tredinnick@gmail.com>2011-08-23 06:29:01 +0000
committerMalcolm Tredinnick <malcolm.tredinnick@gmail.com>2011-08-23 06:29:01 +0000
commit7182cd2284a15cd5094ab6567ae14c6ad3cd901a (patch)
tree2fc9d986ec55a4d8636ea8e897e4375cf2bfa2fc /django
parenta86dde20f05cb85bb2d69c483d084e6c217792cc (diff)
Allow "pk" as a field alias in QuerySet.only() calls.
Thanks to GDorn for the patch. Fixed #15494. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16668 bcc190cf-cafb-0310-a4f2-bffc1f526a37
Diffstat (limited to 'django')
-rw-r--r--django/db/models/sql/query.py9
1 files changed, 7 insertions, 2 deletions
diff --git a/django/db/models/sql/query.py b/django/db/models/sql/query.py
index e5e11f472a..b55de3d766 100644
--- a/django/db/models/sql/query.py
+++ b/django/db/models/sql/query.py
@@ -1791,13 +1791,18 @@ class Query(object):
existing immediate values, but respects existing deferrals.)
"""
existing, defer = self.deferred_loading
+ field_names = set(field_names)
+ if 'pk' in field_names:
+ field_names.remove('pk')
+ field_names.add(self.model._meta.pk.name)
+
if defer:
# Remove any existing deferred names from the current set before
# setting the new names.
- self.deferred_loading = set(field_names).difference(existing), False
+ self.deferred_loading = field_names.difference(existing), False
else:
# Replace any existing "immediate load" field names.
- self.deferred_loading = set(field_names), False
+ self.deferred_loading = field_names, False
def get_loaded_field_names(self):
"""