summaryrefslogtreecommitdiff
path: root/django
diff options
context:
space:
mode:
authorChristopher Medrela <chris.medrela@gmail.com>2013-02-24 16:49:28 +0100
committerChristopher Medrela <chris.medrela@gmail.com>2013-02-24 16:49:28 +0100
commit636c45fc58bcc19d7669a739ccd05ff475381f48 (patch)
treec0798a50caec5f831d90d28257697a732da2d26a /django
parent8503120c1024ad7ec2151196a743d6daec21334b (diff)
Fixed #19890 -- ifchanged templatetag rendered its content twice
The content of ifchanged template tag was rendered twice: first time, to compare it with the previous value and the second time, to return the rendered output.
Diffstat (limited to 'django')
-rw-r--r--django/template/defaulttags.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/django/template/defaulttags.py b/django/template/defaulttags.py
index 7c0772cda8..dbb5b5a0cb 100644
--- a/django/template/defaulttags.py
+++ b/django/template/defaulttags.py
@@ -223,6 +223,7 @@ class IfChangedNode(Node):
if self not in state_frame:
state_frame[self] = None
+ nodelist_true_output = None
try:
if self._varlist:
# Consider multiple parameters. This automatically behaves
@@ -230,13 +231,13 @@ class IfChangedNode(Node):
compare_to = [var.resolve(context, True) for var in self._varlist]
else:
# The "{% ifchanged %}" syntax (without any variables) compares the rendered output.
- compare_to = self.nodelist_true.render(context)
+ compare_to = nodelist_true_output = self.nodelist_true.render(context)
except VariableDoesNotExist:
compare_to = None
if compare_to != state_frame[self]:
state_frame[self] = compare_to
- return self.nodelist_true.render(context)
+ return nodelist_true_output or self.nodelist_true.render(context) # render true block if not already rendered
elif self.nodelist_false:
return self.nodelist_false.render(context)
return ''