diff options
| author | Tim Graham <timograham@gmail.com> | 2014-07-12 09:50:27 -0400 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2014-07-14 08:45:19 -0400 |
| commit | 38e001ab6caa8e5da68dbefd17322adcd2603c21 (patch) | |
| tree | 6512aacff04c7593ec699dd570940eb0eba4eae6 /django | |
| parent | 7affb4ad58e7ee93e4cca0c350315c63035ed648 (diff) | |
Fixed #22789 -- Deprecated django.contrib.webdesign.
Moved the {% lorem %} tag to built-in tags.
Diffstat (limited to 'django')
| -rw-r--r-- | django/contrib/webdesign/__init__.py | 10 | ||||
| -rw-r--r-- | django/contrib/webdesign/templatetags/webdesign.py | 69 | ||||
| -rw-r--r-- | django/contrib/webdesign/tests.py | 8 | ||||
| -rw-r--r-- | django/template/defaulttags.py | 66 | ||||
| -rw-r--r-- | django/utils/lorem_ipsum.py (renamed from django/contrib/webdesign/lorem_ipsum.py) | 0 |
5 files changed, 78 insertions, 75 deletions
diff --git a/django/contrib/webdesign/__init__.py b/django/contrib/webdesign/__init__.py index 2340116bc8..635ed88a67 100644 --- a/django/contrib/webdesign/__init__.py +++ b/django/contrib/webdesign/__init__.py @@ -1 +1,11 @@ +import warnings + +from django.utils.deprecation import RemovedInDjango20Warning + default_app_config = 'django.contrib.webdesign.apps.WebDesignConfig' + +warnings.warn( + "django.contrib.webdesign will be removed in Django 2.0. The " + "{% lorem %} tag is now included in the built-in tags.", + RemovedInDjango20Warning +) diff --git a/django/contrib/webdesign/templatetags/webdesign.py b/django/contrib/webdesign/templatetags/webdesign.py index 2ff73e75d0..d7842df534 100644 --- a/django/contrib/webdesign/templatetags/webdesign.py +++ b/django/contrib/webdesign/templatetags/webdesign.py @@ -1,71 +1,6 @@ -from __future__ import unicode_literals - -from django.contrib.webdesign.lorem_ipsum import words, paragraphs from django import template +from django.template.defaulttags import lorem register = template.Library() - -class LoremNode(template.Node): - def __init__(self, count, method, common): - self.count, self.method, self.common = count, method, common - - def render(self, context): - try: - count = int(self.count.resolve(context)) - except (ValueError, TypeError): - count = 1 - if self.method == 'w': - return words(count, common=self.common) - else: - paras = paragraphs(count, common=self.common) - if self.method == 'p': - paras = ['<p>%s</p>' % p for p in paras] - return '\n\n'.join(paras) - - -@register.tag -def lorem(parser, token): - """ - Creates random Latin text useful for providing test data in templates. - - Usage format:: - - {% lorem [count] [method] [random] %} - - ``count`` is a number (or variable) containing the number of paragraphs or - words to generate (default is 1). - - ``method`` is either ``w`` for words, ``p`` for HTML paragraphs, ``b`` for - plain-text paragraph blocks (default is ``b``). - - ``random`` is the word ``random``, which if given, does not use the common - paragraph (starting "Lorem ipsum dolor sit amet, consectetuer..."). - - Examples: - - * ``{% lorem %}`` will output the common "lorem ipsum" paragraph - * ``{% lorem 3 p %}`` will output the common "lorem ipsum" paragraph - and two random paragraphs each wrapped in HTML ``<p>`` tags - * ``{% lorem 2 w random %}`` will output two random latin words - """ - bits = list(token.split_contents()) - tagname = bits[0] - # Random bit - common = bits[-1] != 'random' - if not common: - bits.pop() - # Method bit - if bits[-1] in ('w', 'p', 'b'): - method = bits.pop() - else: - method = 'b' - # Count bit - if len(bits) > 1: - count = bits.pop() - else: - count = '1' - count = parser.compile_filter(count) - if len(bits) != 1: - raise template.TemplateSyntaxError("Incorrect format for %r tag" % tagname) - return LoremNode(count, method, common) +register.tag(lorem) diff --git a/django/contrib/webdesign/tests.py b/django/contrib/webdesign/tests.py index e4d9635522..239af194b7 100644 --- a/django/contrib/webdesign/tests.py +++ b/django/contrib/webdesign/tests.py @@ -3,19 +3,11 @@ from __future__ import unicode_literals import unittest -from django.contrib.webdesign.lorem_ipsum import paragraphs, words from django.template import loader, Context class WebdesignTest(unittest.TestCase): - def test_words(self): - self.assertEqual(words(7), 'lorem ipsum dolor sit amet consectetur adipisicing') - - def test_paragraphs(self): - self.assertEqual(paragraphs(1), - ['Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.']) - def test_lorem_tag(self): t = loader.get_template_from_string("{% load webdesign %}{% lorem 3 w %}") self.assertEqual(t.render(Context({})), diff --git a/django/template/defaulttags.py b/django/template/defaulttags.py index c08f869e5f..ceeb7f3335 100644 --- a/django/template/defaulttags.py +++ b/django/template/defaulttags.py @@ -19,6 +19,7 @@ from django.template.smartif import IfParser, Literal from django.template.defaultfilters import date from django.utils.deprecation import RemovedInDjango20Warning from django.utils.encoding import force_text, smart_text +from django.utils.lorem_ipsum import words, paragraphs from django.utils.safestring import mark_safe from django.utils.html import format_html from django.utils import six @@ -324,6 +325,24 @@ class IfNode(Node): return '' +class LoremNode(Node): + def __init__(self, count, method, common): + self.count, self.method, self.common = count, method, common + + def render(self, context): + try: + count = int(self.count.resolve(context)) + except (ValueError, TypeError): + count = 1 + if self.method == 'w': + return words(count, common=self.common) + else: + paras = paragraphs(count, common=self.common) + if self.method == 'p': + paras = ['<p>%s</p>' % p for p in paras] + return '\n\n'.join(paras) + + class RegroupNode(Node): def __init__(self, target, expression, var_name): self.target, self.expression = target, expression @@ -1117,6 +1136,53 @@ def load(parser, token): @register.tag +def lorem(parser, token): + """ + Creates random Latin text useful for providing test data in templates. + + Usage format:: + + {% lorem [count] [method] [random] %} + + ``count`` is a number (or variable) containing the number of paragraphs or + words to generate (default is 1). + + ``method`` is either ``w`` for words, ``p`` for HTML paragraphs, ``b`` for + plain-text paragraph blocks (default is ``b``). + + ``random`` is the word ``random``, which if given, does not use the common + paragraph (starting "Lorem ipsum dolor sit amet, consectetuer..."). + + Examples: + + * ``{% lorem %}`` will output the common "lorem ipsum" paragraph + * ``{% lorem 3 p %}`` will output the common "lorem ipsum" paragraph + and two random paragraphs each wrapped in HTML ``<p>`` tags + * ``{% lorem 2 w random %}`` will output two random latin words + """ + bits = list(token.split_contents()) + tagname = bits[0] + # Random bit + common = bits[-1] != 'random' + if not common: + bits.pop() + # Method bit + if bits[-1] in ('w', 'p', 'b'): + method = bits.pop() + else: + method = 'b' + # Count bit + if len(bits) > 1: + count = bits.pop() + else: + count = '1' + count = parser.compile_filter(count) + if len(bits) != 1: + raise TemplateSyntaxError("Incorrect format for %r tag" % tagname) + return LoremNode(count, method, common) + + +@register.tag def now(parser, token): """ Displays the date, formatted according to the given string. diff --git a/django/contrib/webdesign/lorem_ipsum.py b/django/utils/lorem_ipsum.py index b91fecf92b..b91fecf92b 100644 --- a/django/contrib/webdesign/lorem_ipsum.py +++ b/django/utils/lorem_ipsum.py |
