summaryrefslogtreecommitdiff
path: root/django
diff options
context:
space:
mode:
authorMariusz Felisiak <felisiak.mariusz@gmail.com>2023-07-07 13:22:06 +0200
committerGitHub <noreply@github.com>2023-07-07 13:22:06 +0200
commit2584783f46922bcb456ceb9700a3726314df65d3 (patch)
tree04af89572843adc8c2367383dcc3ef4f891db991 /django
parenteed096574fea5c9d82d0dc5952ad439dfde13718 (diff)
Refs #9602 -- Moved AlreadyRegistered/NotRegistered exceptions to django.contrib.admin.exceptions.
Diffstat (limited to 'django')
-rw-r--r--django/contrib/admin/checks.py3
-rw-r--r--django/contrib/admin/exceptions.py12
-rw-r--r--django/contrib/admin/filters.py3
-rw-r--r--django/contrib/admin/options.py6
-rw-r--r--django/contrib/admin/sites.py9
-rw-r--r--django/contrib/admin/views/autocomplete.py3
6 files changed, 17 insertions, 19 deletions
diff --git a/django/contrib/admin/checks.py b/django/contrib/admin/checks.py
index f5aa9b55d4..1665023434 100644
--- a/django/contrib/admin/checks.py
+++ b/django/contrib/admin/checks.py
@@ -3,6 +3,7 @@ from itertools import chain
from django.apps import apps
from django.conf import settings
+from django.contrib.admin.exceptions import NotRegistered
from django.contrib.admin.utils import NotRelationField, flatten, get_fields_from_path
from django.core import checks
from django.core.exceptions import FieldDoesNotExist
@@ -220,8 +221,6 @@ class BaseModelAdminChecks:
ManyToManyField and that the item has a related ModelAdmin with
search_fields defined.
"""
- from django.contrib.admin.sites import NotRegistered
-
try:
field = obj.model._meta.get_field(field_name)
except FieldDoesNotExist:
diff --git a/django/contrib/admin/exceptions.py b/django/contrib/admin/exceptions.py
index 2ee8f625ca..6105eef424 100644
--- a/django/contrib/admin/exceptions.py
+++ b/django/contrib/admin/exceptions.py
@@ -11,3 +11,15 @@ class DisallowedModelAdminToField(SuspiciousOperation):
"""Invalid to_field was passed to admin view via URL query string"""
pass
+
+
+class AlreadyRegistered(Exception):
+ """The model is already registered."""
+
+ pass
+
+
+class NotRegistered(Exception):
+ """The model is not registered."""
+
+ pass
diff --git a/django/contrib/admin/filters.py b/django/contrib/admin/filters.py
index 197d39bf21..06dedf8727 100644
--- a/django/contrib/admin/filters.py
+++ b/django/contrib/admin/filters.py
@@ -7,6 +7,7 @@ certain test -- e.g. being a DateField or ForeignKey.
"""
import datetime
+from django.contrib.admin.exceptions import NotRegistered
from django.contrib.admin.options import IncorrectLookupParameters
from django.contrib.admin.utils import (
build_q_object_from_lookup_parameters,
@@ -257,8 +258,6 @@ class RelatedFieldListFilter(FieldListFilter):
"""
Return the model admin's ordering for related field, if provided.
"""
- from django.contrib.admin.sites import NotRegistered
-
try:
related_admin = model_admin.admin_site.get_model_admin(
field.remote_field.model
diff --git a/django/contrib/admin/options.py b/django/contrib/admin/options.py
index f9760664dd..61ec0a638d 100644
--- a/django/contrib/admin/options.py
+++ b/django/contrib/admin/options.py
@@ -14,7 +14,7 @@ from django.contrib.admin.checks import (
InlineModelAdminChecks,
ModelAdminChecks,
)
-from django.contrib.admin.exceptions import DisallowedModelAdminToField
+from django.contrib.admin.exceptions import DisallowedModelAdminToField, NotRegistered
from django.contrib.admin.templatetags.admin_urls import add_preserved_filters
from django.contrib.admin.utils import (
NestedObjects,
@@ -160,8 +160,6 @@ class BaseModelAdmin(metaclass=forms.MediaDefiningClass):
If kwargs are given, they're passed to the form Field's constructor.
"""
- from django.contrib.admin.sites import NotRegistered
-
# If the field specifies choices, we don't need to look for special
# admin widgets - we just need to use a select widget of some kind.
if db_field.choices:
@@ -252,8 +250,6 @@ class BaseModelAdmin(metaclass=forms.MediaDefiningClass):
ordering. Otherwise don't specify the queryset, let the field decide
(return None in that case).
"""
- from django.contrib.admin.sites import NotRegistered
-
try:
related_admin = self.admin_site.get_model_admin(db_field.remote_field.model)
except NotRegistered:
diff --git a/django/contrib/admin/sites.py b/django/contrib/admin/sites.py
index 41ce85db79..bb02cb08ac 100644
--- a/django/contrib/admin/sites.py
+++ b/django/contrib/admin/sites.py
@@ -4,6 +4,7 @@ from weakref import WeakSet
from django.apps import apps
from django.conf import settings
from django.contrib.admin import ModelAdmin, actions
+from django.contrib.admin.exceptions import AlreadyRegistered, NotRegistered
from django.contrib.admin.views.autocomplete import AutocompleteJsonView
from django.contrib.auth import REDIRECT_FIELD_NAME
from django.core.exceptions import ImproperlyConfigured
@@ -25,14 +26,6 @@ from django.views.i18n import JavaScriptCatalog
all_sites = WeakSet()
-class AlreadyRegistered(Exception):
- pass
-
-
-class NotRegistered(Exception):
- pass
-
-
class AdminSite:
"""
An AdminSite object encapsulates an instance of the Django admin application, ready
diff --git a/django/contrib/admin/views/autocomplete.py b/django/contrib/admin/views/autocomplete.py
index 051b9a31b9..3c12c262ae 100644
--- a/django/contrib/admin/views/autocomplete.py
+++ b/django/contrib/admin/views/autocomplete.py
@@ -1,4 +1,5 @@
from django.apps import apps
+from django.contrib.admin.exceptions import NotRegistered
from django.core.exceptions import FieldDoesNotExist, PermissionDenied
from django.http import Http404, JsonResponse
from django.views.generic.list import BaseListView
@@ -74,8 +75,6 @@ class AutocompleteJsonView(BaseListView):
Raise Http404 if the target model admin is not configured properly with
search_fields.
"""
- from django.contrib.admin.sites import NotRegistered
-
term = request.GET.get("term", "")
try:
app_label = request.GET["app_label"]