summaryrefslogtreecommitdiff
path: root/django
diff options
context:
space:
mode:
authorClaude Paroz <claude@2xlibre.net>2013-03-20 10:41:53 +0100
committerClaude Paroz <claude@2xlibre.net>2013-03-20 10:41:53 +0100
commit23490a2394bf03e119e4c9a7a09a9ba35edad430 (patch)
treec0f630706965ff28f7e2ab34a0f2945dbfe75cb8 /django
parentccb87f97ada8c846e7d0860d95b619a199af243a (diff)
Revert "Fixed 19895 -- Made second iteration over invalid queryset raise an exception too"
This reverts commit 2cd0edaa477b327024e4007c8eaf46646dcd0f21. This commit was the cause of a memory leak. See ticket for more details. Thanks Anssi Kääriäinen for identifying the source of the bug.
Diffstat (limited to 'django')
-rw-r--r--django/db/models/query.py14
1 files changed, 1 insertions, 13 deletions
diff --git a/django/db/models/query.py b/django/db/models/query.py
index 22c7cfba32..7ddd933772 100644
--- a/django/db/models/query.py
+++ b/django/db/models/query.py
@@ -104,7 +104,7 @@ class QuerySet(object):
len(self)
if self._result_cache is None:
- self._iter = self._safe_iterator(self.iterator())
+ self._iter = self.iterator()
self._result_cache = []
if self._iter:
return self._result_iter()
@@ -341,18 +341,6 @@ class QuerySet(object):
yield obj
- def _safe_iterator(self, iterator):
- # ensure result cache is cleared when iterating over a queryset
- # raises an exception
- try:
- for item in iterator:
- yield item
- except StopIteration:
- raise
- except Exception:
- self._result_cache = None
- raise
-
def aggregate(self, *args, **kwargs):
"""
Returns a dictionary containing the calculations (aggregation)