diff options
| author | Jon Dufresne <jon.dufresne@gmail.com> | 2017-06-01 16:08:59 -0700 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2017-06-01 19:08:59 -0400 |
| commit | 2c69824e5ab5ddf4b9964c4cf9f9e16ff3bb7929 (patch) | |
| tree | 65b8e60b858e4f073a04c2bbf976b8f43fe0cff6 /django/forms | |
| parent | edee5a8de6afb34a9247de2bb73ab66397a6e573 (diff) | |
Refs #23968 -- Removed unnecessary lists, generators, and tuple calls.
Diffstat (limited to 'django/forms')
| -rw-r--r-- | django/forms/boundfield.py | 4 | ||||
| -rw-r--r-- | django/forms/fields.py | 4 | ||||
| -rw-r--r-- | django/forms/models.py | 6 |
3 files changed, 7 insertions, 7 deletions
diff --git a/django/forms/boundfield.py b/django/forms/boundfield.py index 128d9ce80a..771661ba6a 100644 --- a/django/forms/boundfield.py +++ b/django/forms/boundfield.py @@ -47,10 +47,10 @@ class BoundField: id_ = self.field.widget.attrs.get('id') or self.auto_id attrs = {'id': id_} if id_ else {} attrs = self.build_widget_attrs(attrs) - return list( + return [ BoundWidget(self.field.widget, widget, self.form.renderer) for widget in self.field.widget.subwidgets(self.html_name, self.value(), attrs=attrs) - ) + ] def __bool__(self): # BoundField evaluates to True even if it doesn't have subwidgets. diff --git a/django/forms/fields.py b/django/forms/fields.py index d665606745..eb16f2c353 100644 --- a/django/forms/fields.py +++ b/django/forms/fields.py @@ -873,8 +873,8 @@ class MultipleChoiceField(ChoiceField): data = [] if len(initial) != len(data): return True - initial_set = set(str(value) for value in initial) - data_set = set(str(value) for value in data) + initial_set = {str(value) for value in initial} + data_set = {str(value) for value in data} return data_set != initial_set diff --git a/django/forms/models.py b/django/forms/models.py index f4c415ed4f..98b56392d0 100644 --- a/django/forms/models.py +++ b/django/forms/models.py @@ -1289,7 +1289,7 @@ class ModelMultipleChoiceField(ModelChoiceField): params={'pk': pk}, ) qs = self.queryset.filter(**{'%s__in' % key: value}) - pks = set(str(getattr(o, key)) for o in qs) + pks = {str(getattr(o, key)) for o in qs} for val in value: if str(val) not in pks: raise ValidationError( @@ -1313,8 +1313,8 @@ class ModelMultipleChoiceField(ModelChoiceField): data = [] if len(initial) != len(data): return True - initial_set = set(str(value) for value in self.prepare_value(initial)) - data_set = set(str(value) for value in data) + initial_set = {str(value) for value in self.prepare_value(initial)} + data_set = {str(value) for value in data} return data_set != initial_set |
