diff options
| author | Sergey Fedoseev <fedoseev.sergey@gmail.com> | 2017-12-29 03:35:41 +0500 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2017-12-28 17:35:41 -0500 |
| commit | ae6fa914aa2f43d39ae491ac7d3140dda69702fa (patch) | |
| tree | 8ecea479750200eed8f047381a167097404db8f9 /django/db | |
| parent | 46d1af2e82c2b2a6976397719afde33b5cff2498 (diff) | |
Fixed #28926 -- Fixed loss of precision of big DurationField values on SQLite and MySQL.
Diffstat (limited to 'django/db')
| -rw-r--r-- | django/db/backends/mysql/operations.py | 3 | ||||
| -rw-r--r-- | django/db/backends/sqlite3/base.py | 3 | ||||
| -rw-r--r-- | django/db/models/fields/__init__.py | 5 |
3 files changed, 6 insertions, 5 deletions
diff --git a/django/db/backends/mysql/operations.py b/django/db/backends/mysql/operations.py index 7c901d78d8..ad4c13652e 100644 --- a/django/db/backends/mysql/operations.py +++ b/django/db/backends/mysql/operations.py @@ -3,6 +3,7 @@ import uuid from django.conf import settings from django.db.backends.base.operations import BaseDatabaseOperations from django.utils import timezone +from django.utils.duration import duration_microseconds from django.utils.encoding import force_text @@ -105,7 +106,7 @@ class DatabaseOperations(BaseDatabaseOperations): return "TIME(%s)" % (field_name) def date_interval_sql(self, timedelta): - return "INTERVAL '%06f' SECOND_MICROSECOND" % timedelta.total_seconds() + return 'INTERVAL %s MICROSECOND' % duration_microseconds(timedelta) def format_for_duration_arithmetic(self, sql): return 'INTERVAL %s MICROSECOND' % sql diff --git a/django/db/backends/sqlite3/base.py b/django/db/backends/sqlite3/base.py index d15352dcc6..d3caa6d12a 100644 --- a/django/db/backends/sqlite3/base.py +++ b/django/db/backends/sqlite3/base.py @@ -17,6 +17,7 @@ from django.utils import timezone from django.utils.dateparse import ( parse_date, parse_datetime, parse_duration, parse_time, ) +from django.utils.duration import duration_microseconds from .client import DatabaseClient # isort:skip from .creation import DatabaseCreation # isort:skip @@ -471,7 +472,7 @@ def _sqlite_time_diff(lhs, rhs): def _sqlite_timestamp_diff(lhs, rhs): left = backend_utils.typecast_timestamp(lhs) right = backend_utils.typecast_timestamp(rhs) - return (left - right).total_seconds() * 1000000 + return duration_microseconds(left - right) def _sqlite_regexp(re_pattern, re_string): diff --git a/django/db/models/fields/__init__.py b/django/db/models/fields/__init__.py index a67cf9b647..188b5bb907 100644 --- a/django/db/models/fields/__init__.py +++ b/django/db/models/fields/__init__.py @@ -24,7 +24,7 @@ from django.utils.datastructures import DictWrapper from django.utils.dateparse import ( parse_date, parse_datetime, parse_duration, parse_time, ) -from django.utils.duration import duration_string +from django.utils.duration import duration_microseconds, duration_string from django.utils.encoding import force_bytes, smart_text from django.utils.functional import Promise, cached_property from django.utils.ipv6 import clean_ipv6_address @@ -1617,8 +1617,7 @@ class DurationField(Field): return value if value is None: return None - # Discard any fractional microseconds due to floating point arithmetic. - return round(value.total_seconds() * 1000000) + return duration_microseconds(value) def get_db_converters(self, connection): converters = [] |
