summaryrefslogtreecommitdiff
path: root/django/db/models/sql
diff options
context:
space:
mode:
authorCarl Meyer <carl@oddbird.net>2012-02-22 05:26:50 +0000
committerCarl Meyer <carl@oddbird.net>2012-02-22 05:26:50 +0000
commit354c84d277e3a9516cd2af1567eb02cb4da1a3e4 (patch)
tree5e72bff88028889e482ea5b8b865c8886f17add0 /django/db/models/sql
parent3ac0961e1ec3f935474e3c1c3f16bee1cc5ae54a (diff)
Fixed #17678 -- Corrected setup of _meta.proxy_for_model and added _meta.concrete_model. Thanks Anssi Kääriäinen.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17573 bcc190cf-cafb-0310-a4f2-bffc1f526a37
Diffstat (limited to 'django/db/models/sql')
-rw-r--r--django/db/models/sql/compiler.py4
-rw-r--r--django/db/models/sql/query.py19
2 files changed, 6 insertions, 17 deletions
diff --git a/django/db/models/sql/compiler.py b/django/db/models/sql/compiler.py
index 72948f9cd7..6c516e2b21 100644
--- a/django/db/models/sql/compiler.py
+++ b/django/db/models/sql/compiler.py
@@ -7,7 +7,7 @@ from django.db.models.query_utils import select_related_descend
from django.db.models.sql.constants import *
from django.db.models.sql.datastructures import EmptyResultSet
from django.db.models.sql.expressions import SQLEvaluator
-from django.db.models.sql.query import get_proxied_model, get_order_dir, Query
+from django.db.models.sql.query import get_order_dir, Query
from django.db.utils import DatabaseError
@@ -266,7 +266,7 @@ class SQLCompiler(object):
aliases = set()
only_load = self.deferred_to_columns()
# Skip all proxy to the root proxied model
- proxied_model = get_proxied_model(opts)
+ proxied_model = opts.concrete_model
if start_alias:
seen = {None: start_alias}
diff --git a/django/db/models/sql/query.py b/django/db/models/sql/query.py
index a78df343a7..693dde3b40 100644
--- a/django/db/models/sql/query.py
+++ b/django/db/models/sql/query.py
@@ -575,10 +575,7 @@ class Query(object):
return
orig_opts = self.model._meta
seen = {}
- if orig_opts.proxy:
- must_include = {orig_opts.proxy_for_model: set([orig_opts.pk])}
- else:
- must_include = {self.model: set([orig_opts.pk])}
+ must_include = {orig_opts.concrete_model: set([orig_opts.pk])}
for field_name in field_names:
parts = field_name.split(LOOKUP_SEP)
cur_model = self.model
@@ -586,7 +583,7 @@ class Query(object):
for name in parts[:-1]:
old_model = cur_model
source = opts.get_field_by_name(name)[0]
- cur_model = opts.get_field_by_name(name)[0].rel.to
+ cur_model = source.rel.to
opts = cur_model._meta
# Even if we're "just passing through" this model, we must add
# both the current model's pk and the related reference field
@@ -946,7 +943,7 @@ class Query(object):
seen = {None: root_alias}
# Skip all proxy to the root proxied model
- proxied_model = get_proxied_model(opts)
+ proxied_model = opts.concrete_model
for field, model in opts.get_fields_with_model():
if model not in seen:
@@ -1325,7 +1322,7 @@ class Query(object):
if model:
# The field lives on a base class of the current model.
# Skip the chain of proxy to the concrete proxied model
- proxied_model = get_proxied_model(opts)
+ proxied_model = opts.concrete_model
for int_model in opts.get_base_chain(model):
if int_model is proxied_model:
@@ -1990,11 +1987,3 @@ def add_to_dict(data, key, value):
data[key].add(value)
else:
data[key] = set([value])
-
-def get_proxied_model(opts):
- int_opts = opts
- proxied_model = None
- while int_opts.proxy:
- proxied_model = int_opts.proxy_for_model
- int_opts = proxied_model._meta
- return proxied_model