summaryrefslogtreecommitdiff
path: root/django/db/models/fields
diff options
context:
space:
mode:
authorDavid Wobrock <david.wobrock@gmail.com>2023-04-18 10:20:32 +0200
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2023-04-18 12:46:27 +0200
commit8b1ff0da4b162e87edebd94e61f2cd153e9e159d (patch)
tree537798f33a0a9458ea1c4728616ba207b3a44dac /django/db/models/fields
parent9bbf97bcdb488bb11aebb5bd405549fbec6852cd (diff)
Refs #16055 -- Deprecated get_joining_columns()/get_reverse_joining_columns() methods.
Diffstat (limited to 'django/db/models/fields')
-rw-r--r--django/db/models/fields/related.py12
-rw-r--r--django/db/models/fields/reverse_related.py7
2 files changed, 19 insertions, 0 deletions
diff --git a/django/db/models/fields/related.py b/django/db/models/fields/related.py
index 7a49861164..2c0527d2b7 100644
--- a/django/db/models/fields/related.py
+++ b/django/db/models/fields/related.py
@@ -1,5 +1,6 @@
import functools
import inspect
+import warnings
from functools import partial
from django import forms
@@ -13,6 +14,7 @@ from django.db.models.constants import LOOKUP_SEP
from django.db.models.deletion import CASCADE, SET_DEFAULT, SET_NULL
from django.db.models.query_utils import PathInfo
from django.db.models.utils import make_model_tuple
+from django.utils.deprecation import RemovedInDjango60Warning
from django.utils.functional import cached_property
from django.utils.translation import gettext_lazy as _
@@ -777,12 +779,22 @@ class ForeignObject(RelatedField):
return attname, None
def get_joining_columns(self, reverse_join=False):
+ warnings.warn(
+ "ForeignObject.get_joining_columns() is deprecated. Use "
+ "get_joining_fields() instead.",
+ RemovedInDjango60Warning,
+ )
source = self.reverse_related_fields if reverse_join else self.related_fields
return tuple(
(lhs_field.column, rhs_field.column) for lhs_field, rhs_field in source
)
def get_reverse_joining_columns(self):
+ warnings.warn(
+ "ForeignObject.get_reverse_joining_columns() is deprecated. Use "
+ "get_reverse_joining_fields() instead.",
+ RemovedInDjango60Warning,
+ )
return self.get_joining_columns(reverse_join=True)
def get_joining_fields(self, reverse_join=False):
diff --git a/django/db/models/fields/reverse_related.py b/django/db/models/fields/reverse_related.py
index f3da8f8bf2..c74e92ba89 100644
--- a/django/db/models/fields/reverse_related.py
+++ b/django/db/models/fields/reverse_related.py
@@ -8,8 +8,10 @@ in the ``remote_field`` attribute of the field.
They also act as reverse fields for the purposes of the Meta API because
they're the closest concept currently available.
"""
+import warnings
from django.core import exceptions
+from django.utils.deprecation import RemovedInDjango60Warning
from django.utils.functional import cached_property
from django.utils.hashable import make_hashable
@@ -193,6 +195,11 @@ class ForeignObjectRel(FieldCacheMixin):
return bool(self.related_name) and self.related_name[-1] == "+"
def get_joining_columns(self):
+ warnings.warn(
+ "ForeignObjectRel.get_joining_columns() is deprecated. Use "
+ "get_joining_fields() instead.",
+ RemovedInDjango60Warning,
+ )
return self.field.get_reverse_joining_columns()
def get_joining_fields(self):