summaryrefslogtreecommitdiff
path: root/django/contrib/postgres/fields
diff options
context:
space:
mode:
authorNick Pope <nick.pope@flightdataservices.com>2017-12-11 12:08:45 +0000
committerTim Graham <timograham@gmail.com>2017-12-11 07:08:45 -0500
commitd13a9e44ded4e93570c6ba42ec84e45ddca2505b (patch)
tree0df16e6538d8794c39bd62b5a46879b8abe6572c /django/contrib/postgres/fields
parenta9e5ac823df8ba8b786b6450c967ca378c008d0e (diff)
Fixed #28909 -- Simplified code using tuple/list/set/dict unpacking.
Diffstat (limited to 'django/contrib/postgres/fields')
-rw-r--r--django/contrib/postgres/fields/array.py7
-rw-r--r--django/contrib/postgres/fields/hstore.py7
-rw-r--r--django/contrib/postgres/fields/jsonb.py7
3 files changed, 10 insertions, 11 deletions
diff --git a/django/contrib/postgres/fields/array.py b/django/contrib/postgres/fields/array.py
index 6a8fbd0e91..bf5666e2da 100644
--- a/django/contrib/postgres/fields/array.py
+++ b/django/contrib/postgres/fields/array.py
@@ -183,13 +183,12 @@ class ArrayField(CheckFieldDefaultMixin, Field):
)
def formfield(self, **kwargs):
- defaults = {
+ return super().formfield(**{
'form_class': SimpleArrayField,
'base_field': self.base_field.formfield(),
'max_length': self.size,
- }
- defaults.update(kwargs)
- return super().formfield(**defaults)
+ **kwargs,
+ })
@ArrayField.register_lookup
diff --git a/django/contrib/postgres/fields/hstore.py b/django/contrib/postgres/fields/hstore.py
index 82f731f8bf..d47b34d459 100644
--- a/django/contrib/postgres/fields/hstore.py
+++ b/django/contrib/postgres/fields/hstore.py
@@ -44,11 +44,10 @@ class HStoreField(Field):
return json.dumps(self.value_from_object(obj))
def formfield(self, **kwargs):
- defaults = {
+ return super().formfield(**{
'form_class': forms.HStoreField,
- }
- defaults.update(kwargs)
- return super().formfield(**defaults)
+ **kwargs,
+ })
def get_prep_value(self, value):
value = super().get_prep_value(value)
diff --git a/django/contrib/postgres/fields/jsonb.py b/django/contrib/postgres/fields/jsonb.py
index 4ed441003b..3c27607acd 100644
--- a/django/contrib/postgres/fields/jsonb.py
+++ b/django/contrib/postgres/fields/jsonb.py
@@ -77,9 +77,10 @@ class JSONField(CheckFieldDefaultMixin, Field):
return self.value_from_object(obj)
def formfield(self, **kwargs):
- defaults = {'form_class': forms.JSONField}
- defaults.update(kwargs)
- return super().formfield(**defaults)
+ return super().formfield(**{
+ 'form_class': forms.JSONField,
+ **kwargs,
+ })
JSONField.register_lookup(lookups.DataContains)