summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Charette <charette.s@gmail.com>2024-02-03 01:10:41 -0500
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2024-02-04 09:31:06 +0100
commitfe1cb62f5c3f87fafc4a6b52fee2ccc6c80c41e2 (patch)
tree42805b8fe83e29846aaf38ab3370e25d7eb4819c
parentdfc77637ea5c1aa81caa72b1cf900e6931d61b54 (diff)
Refs #35149 -- Made equivalent db_default alterations noops.
This allows for an easier transition of preserving the literal nature of non-compilable db_default.
-rw-r--r--django/db/backends/base/schema.py8
-rw-r--r--tests/schema/tests.py17
2 files changed, 25 insertions, 0 deletions
diff --git a/django/db/backends/base/schema.py b/django/db/backends/base/schema.py
index dad3f8d916..ed91c6ab1b 100644
--- a/django/db/backends/base/schema.py
+++ b/django/db/backends/base/schema.py
@@ -1640,6 +1640,14 @@ class BaseDatabaseSchemaEditor:
):
old_kwargs.pop("to", None)
new_kwargs.pop("to", None)
+ # db_default can take many form but result in the same SQL.
+ if (
+ old_kwargs.get("db_default")
+ and new_kwargs.get("db_default")
+ and self.db_default_sql(old_field) == self.db_default_sql(new_field)
+ ):
+ old_kwargs.pop("db_default")
+ new_kwargs.pop("db_default")
return self.quote_name(old_field.column) != self.quote_name(
new_field.column
) or (old_path, old_args, old_kwargs) != (new_path, new_args, new_kwargs)
diff --git a/tests/schema/tests.py b/tests/schema/tests.py
index cde3d7f991..04ad299aa6 100644
--- a/tests/schema/tests.py
+++ b/tests/schema/tests.py
@@ -2316,6 +2316,23 @@ class SchemaTests(TransactionTestCase):
columns = self.column_classes(Author)
self.assertIn("(missing)", columns["description"][1].default)
+ @isolate_apps("schema")
+ def test_db_default_equivalent_sql_noop(self):
+ class Author(Model):
+ name = TextField(db_default=Value("foo"))
+
+ class Meta:
+ app_label = "schema"
+
+ with connection.schema_editor() as editor:
+ editor.create_model(Author)
+
+ new_field = TextField(db_default="foo")
+ new_field.set_attributes_from_name("name")
+ new_field.model = Author
+ with connection.schema_editor() as editor, self.assertNumQueries(0):
+ editor.alter_field(Author, Author._meta.get_field("name"), new_field)
+
@skipUnlessDBFeature(
"supports_column_check_constraints", "can_introspect_check_constraints"
)