summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Graham <timograham@gmail.com>2018-03-16 10:21:13 -0400
committerTim Graham <timograham@gmail.com>2018-03-16 11:43:41 -0400
commitf8b98f0edc501ca1ca2d04d1d5938cbb68d11db5 (patch)
treeb8e8c7e7abf1f38fdd58853ca4d3ec21855b4573
parent362813d6287925b8f63f0b107c55a74d95f5825e (diff)
Removed DatabaseFeatures.can_introspect_null.
The only known usage is in the unmaintained django-pymssql project.
-rw-r--r--django/db/backends/base/features.py9
-rw-r--r--tests/inspectdb/tests.py5
-rw-r--r--tests/introspection/tests.py1
3 files changed, 2 insertions, 13 deletions
diff --git a/django/db/backends/base/features.py b/django/db/backends/base/features.py
index 9a349ed8c0..7d3078c1f8 100644
--- a/django/db/backends/base/features.py
+++ b/django/db/backends/base/features.py
@@ -109,13 +109,6 @@ class BaseDatabaseFeatures:
# Does the backend reset sequences between tests?
supports_sequence_reset = True
- # Can the backend determine reliably if a field is nullable?
- # Note that this is separate from interprets_empty_strings_as_nulls,
- # although the latter feature, when true, interferes with correct
- # setting (and introspection) of CharFields' nullability.
- # This is True for all core backends.
- can_introspect_null = True
-
# Can the backend introspect the default value of a column?
can_introspect_default = True
@@ -286,6 +279,6 @@ class BaseDatabaseFeatures:
introspection results; it should provide expectations, not run an
introspection itself.
"""
- if self.can_introspect_null and field and field.null:
+ if field and field.null:
return 'NullBooleanField'
return 'BooleanField'
diff --git a/tests/inspectdb/tests.py b/tests/inspectdb/tests.py
index 1ec520ace0..794ebc2660 100644
--- a/tests/inspectdb/tests.py
+++ b/tests/inspectdb/tests.py
@@ -104,10 +104,7 @@ class InspectDBTestCase(TestCase):
if 'BooleanField' in null_bool_field_type:
assertFieldType('null_bool_field', "models.{}()".format(null_bool_field_type))
else:
- if connection.features.can_introspect_null:
- assertFieldType('null_bool_field', "models.{}(blank=True, null=True)".format(null_bool_field_type))
- else:
- assertFieldType('null_bool_field', "models.{}()".format(null_bool_field_type))
+ assertFieldType('null_bool_field', "models.{}(blank=True, null=True)".format(null_bool_field_type))
if connection.features.can_introspect_decimal_field:
assertFieldType('decimal_field', "models.DecimalField(max_digits=6, decimal_places=1)")
diff --git a/tests/introspection/tests.py b/tests/introspection/tests.py
index ce102fcdad..ed5556fc20 100644
--- a/tests/introspection/tests.py
+++ b/tests/introspection/tests.py
@@ -92,7 +92,6 @@ class IntrospectionTests(TransactionTestCase):
[30, 30, 254]
)
- @skipUnlessDBFeature('can_introspect_null')
def test_get_table_description_nullable(self):
with connection.cursor() as cursor:
desc = connection.introspection.get_table_description(cursor, Reporter._meta.db_table)