summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClaude Paroz <claude@2xlibre.net>2012-11-17 17:06:24 +0100
committerClaude Paroz <claude@2xlibre.net>2012-11-17 17:06:24 +0100
commitec9d6b1122dd09168d8b2dbcabc745f22f0ef766 (patch)
tree5d2192d15ab6179d53b7af5fefa6deca8a34d590
parent8c69278764ae31b0cd495d21b84444bf2471c103 (diff)
Fixed #19226 -- Applied linebreaksbr to read-only fields in admin
Thanks shadow for the report, and Melevir and thiderman for the patch.
-rw-r--r--django/contrib/admin/templates/admin/includes/fieldset.html2
-rw-r--r--tests/regressiontests/admin_views/admin.py9
-rw-r--r--tests/regressiontests/admin_views/tests.py4
3 files changed, 13 insertions, 2 deletions
diff --git a/django/contrib/admin/templates/admin/includes/fieldset.html b/django/contrib/admin/templates/admin/includes/fieldset.html
index c8d08c880f..09bc971d2f 100644
--- a/django/contrib/admin/templates/admin/includes/fieldset.html
+++ b/django/contrib/admin/templates/admin/includes/fieldset.html
@@ -14,7 +14,7 @@
{% else %}
{{ field.label_tag }}
{% if field.is_readonly %}
- <p>{{ field.contents }}</p>
+ <p>{{ field.contents|linebreaksbr }}</p>
{% else %}
{{ field.field }}
{% endif %}
diff --git a/tests/regressiontests/admin_views/admin.py b/tests/regressiontests/admin_views/admin.py
index a5476e9eb7..6bb6ba59b0 100644
--- a/tests/regressiontests/admin_views/admin.py
+++ b/tests/regressiontests/admin_views/admin.py
@@ -388,7 +388,10 @@ class PrePopulatedPostAdmin(admin.ModelAdmin):
class PostAdmin(admin.ModelAdmin):
list_display = ['title', 'public']
- readonly_fields = ('posted', 'awesomeness_level', 'coolness', 'value', lambda obj: "foo")
+ readonly_fields = (
+ 'posted', 'awesomeness_level', 'coolness', 'value', 'multiline',
+ lambda obj: "foo"
+ )
inlines = [
LinkInline
@@ -402,6 +405,10 @@ class PostAdmin(admin.ModelAdmin):
def value(self, instance):
return 1000
+
+ def multiline(self, instance):
+ return "Multiline\ntest\nstring"
+
value.short_description = 'Value in $US'
diff --git a/tests/regressiontests/admin_views/tests.py b/tests/regressiontests/admin_views/tests.py
index 72dc6a3f97..b5e0f407e5 100644
--- a/tests/regressiontests/admin_views/tests.py
+++ b/tests/regressiontests/admin_views/tests.py
@@ -3149,6 +3149,10 @@ class ReadonlyTest(TestCase):
self.assertContains(response, "Very awesome.")
self.assertContains(response, "Unkown coolness.")
self.assertContains(response, "foo")
+
+ # Checks that multiline text in a readonly field gets <br /> tags
+ self.assertContains(response, "Multiline<br />test<br />string")
+
self.assertContains(response,
formats.localize(datetime.date.today() - datetime.timedelta(days=7))
)