summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Godwin <andrew@aeracode.org>2011-01-14 23:19:50 +0000
committerAndrew Godwin <andrew@aeracode.org>2011-01-14 23:19:50 +0000
commiteb9ebb1931de3b41b7cfe9b48e1f7bfa506d3c4e (patch)
treec0ab8dcb09efb80ec56511755b7e72088be07722
parent88dfbc50fb80187a0e226bbbee58e7cf0d03cbda (diff)
[1.2.X] Fixed #11193 -- WSGI handler not properly handling lock on error in load_middleware. Thanks to Phillip Sitbon.
Backport of [15205] from trunk git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.2.X@15206 bcc190cf-cafb-0310-a4f2-bffc1f526a37
-rw-r--r--django/core/handlers/wsgi.py14
1 files changed, 10 insertions, 4 deletions
diff --git a/django/core/handlers/wsgi.py b/django/core/handlers/wsgi.py
index 927b098815..ace3ed31ca 100644
--- a/django/core/handlers/wsgi.py
+++ b/django/core/handlers/wsgi.py
@@ -225,10 +225,16 @@ class WSGIHandler(base.BaseHandler):
# settings weren't available.
if self._request_middleware is None:
self.initLock.acquire()
- # Check that middleware is still uninitialised.
- if self._request_middleware is None:
- self.load_middleware()
- self.initLock.release()
+ try:
+ # Check that middleware is still uninitialised.
+ if self._request_middleware is None:
+ self.load_middleware()
+ except:
+ # Unload whatever middleware we got
+ self._request_middleware = None
+ raise
+ finally:
+ self.initLock.release()
set_script_prefix(base.get_script_name(environ))
signals.request_started.send(sender=self.__class__)