diff options
| author | Jannis Leidel <jannis@leidel.info> | 2010-12-21 15:15:28 +0000 |
|---|---|---|
| committer | Jannis Leidel <jannis@leidel.info> | 2010-12-21 15:15:28 +0000 |
| commit | eb18ea78998f28687b01adcd83970a472dad5e75 (patch) | |
| tree | 8d8cf2bb0bebf6129018eb3f73846c0695e56cd9 | |
| parent | af1c8b2cfaf04072dff481982b2b064e10f84488 (diff) | |
[1.2.X] Fixed #13782 -- Added CSS for errors in textareas and multiple fields in one line. Thanks, julien.
Backport from trunk (r14999).
git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.2.X@15003 bcc190cf-cafb-0310-a4f2-bffc1f526a37
| -rw-r--r-- | django/contrib/admin/helpers.py | 3 | ||||
| -rw-r--r-- | django/contrib/admin/media/css/base.css | 2 | ||||
| -rw-r--r-- | django/contrib/admin/templates/admin/includes/fieldset.html | 7 |
3 files changed, 8 insertions, 4 deletions
diff --git a/django/contrib/admin/helpers.py b/django/contrib/admin/helpers.py index 6bcaf80248..e5d85a674c 100644 --- a/django/contrib/admin/helpers.py +++ b/django/contrib/admin/helpers.py @@ -128,6 +128,9 @@ class AdminField(object): attrs = classes and {'class': u' '.join(classes)} or {} return self.field.label_tag(contents=contents, attrs=attrs) + def errors(self): + return mark_safe(self.field.errors.as_ul()) + class AdminReadonlyField(object): def __init__(self, form, field, is_first, model_admin=None): label = label_for_field(field, form._meta.model, model_admin) diff --git a/django/contrib/admin/media/css/base.css b/django/contrib/admin/media/css/base.css index 9c1f71f810..29f7c83b70 100644 --- a/django/contrib/admin/media/css/base.css +++ b/django/contrib/admin/media/css/base.css @@ -496,7 +496,7 @@ td ul.errorlist li { background: #ffc; } -.errors input, .errors select { +.errors input, .errors select, .errors textarea { border: 1px solid red; } diff --git a/django/contrib/admin/templates/admin/includes/fieldset.html b/django/contrib/admin/templates/admin/includes/fieldset.html index e3b1c6a38b..addfd0854c 100644 --- a/django/contrib/admin/templates/admin/includes/fieldset.html +++ b/django/contrib/admin/templates/admin/includes/fieldset.html @@ -4,10 +4,11 @@ <div class="description">{{ fieldset.description|safe }}</div> {% endif %} {% for line in fieldset %} - <div class="form-row{% if line.errors %} errors{% endif %}{% for field in line %} {{ field.field.name }}{% endfor %}"> - {{ line.errors }} + <div class="form-row{% if line.fields|length_is:'1' and line.errors %} errors{% endif %}{% for field in line %} {{ field.field.name }}{% endfor %}"> + {% if line.fields|length_is:'1' %}{{ line.errors }}{% endif %} {% for field in line %} - <div{% if not line.fields|length_is:"1" %} class="field-box"{% endif %}> + <div{% if not line.fields|length_is:'1' %} class="field-box{% if not field.is_readonly and field.errors %} errors{% endif %}"{% endif %}> + {% if not line.fields|length_is:'1' and not field.is_readonly %}{{ field.errors }}{% endif %} {% if field.is_checkbox %} {{ field.field }}{{ field.label_tag }} {% else %} |
