diff options
| author | Chinmoy Chakraborty <chinmoy12c@gmail.com> | 2023-09-29 09:48:45 +0200 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2023-09-29 09:52:39 +0200 |
| commit | e99c7d8847e9006f877ab3cea47f1977652af71f (patch) | |
| tree | 3cc1f93b91773efc6d12f3a9b94c847b15ec50fd | |
| parent | 6ad0dbc8d90ef37731608f7ac3d6e1d62cc8c765 (diff) | |
Refs #34657 -- Made assertInHTML() use unparsed needle in error messages.
| -rw-r--r-- | AUTHORS | 1 | ||||
| -rw-r--r-- | django/test/testcases.py | 6 | ||||
| -rw-r--r-- | tests/test_utils/tests.py | 7 |
3 files changed, 11 insertions, 3 deletions
@@ -196,6 +196,7 @@ answer newbie questions, and generally made Django that much better: charly.wilhelm@gmail.com Chason Chaffin <chason@gmail.com> Cheng Zhang + Chinmoy Chakraborty <chinmoy12c@gmail.com> Chris Adams Chris Beaven <smileychris@gmail.com> Chris Bennett <chrisrbennett@yahoo.com> diff --git a/django/test/testcases.py b/django/test/testcases.py index 6b44c0bd29..60a04bf5d2 100644 --- a/django/test/testcases.py +++ b/django/test/testcases.py @@ -873,13 +873,13 @@ class SimpleTestCase(unittest.TestCase): self.fail(self._formatMessage(msg, standardMsg)) def assertInHTML(self, needle, haystack, count=None, msg_prefix=""): - needle = assert_and_parse_html( + parsed_needle = assert_and_parse_html( self, needle, None, "First argument is not valid HTML:" ) - haystack = assert_and_parse_html( + parsed_haystack = assert_and_parse_html( self, haystack, None, "Second argument is not valid HTML:" ) - real_count = haystack.count(needle) + real_count = parsed_haystack.count(parsed_needle) if count is not None: self.assertEqual( real_count, diff --git a/tests/test_utils/tests.py b/tests/test_utils/tests.py index 8b07d631fb..3ee78a60a3 100644 --- a/tests/test_utils/tests.py +++ b/tests/test_utils/tests.py @@ -983,6 +983,13 @@ class HTMLEqualTests(SimpleTestCase): ) +class InHTMLTests(SimpleTestCase): + def test_needle_msg(self): + msg = "False is not true : Couldn't find '<b>Hello</b>' in response" + with self.assertRaisesMessage(AssertionError, msg): + self.assertInHTML("<b>Hello</b>", "<p>Test</p>") + + class JSONEqualTests(SimpleTestCase): def test_simple_equal(self): json1 = '{"attr1": "foo", "attr2":"baz"}' |