summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuke Plant <L.Plant.98@cantab.net>2011-01-13 23:18:54 +0000
committerLuke Plant <L.Plant.98@cantab.net>2011-01-13 23:18:54 +0000
commitcfcb591dd8d3f1ead78e0bdb9578852312768f97 (patch)
treec7af91a4395d661ec7c76fcb90501ac37297b7b6
parenta6b9dbc57c39e2746f0ec70d9c7f3d4b93e0e1a6 (diff)
Fixed some bugs with formtools tests.
Without these checks, it is possible for the tests to pass by virtue of asserts never being reached for some reason (very possible in this case, due to handling of security hashes). git-svn-id: http://code.djangoproject.com/svn/django/trunk@15198 bcc190cf-cafb-0310-a4f2-bffc1f526a37
-rw-r--r--django/contrib/formtools/tests/__init__.py6
1 files changed, 6 insertions, 0 deletions
diff --git a/django/contrib/formtools/tests/__init__.py b/django/contrib/formtools/tests/__init__.py
index 1ec71d3e33..6a9737b038 100644
--- a/django/contrib/formtools/tests/__init__.py
+++ b/django/contrib/formtools/tests/__init__.py
@@ -356,11 +356,13 @@ class WizardTests(TestCase):
Regression test for ticket #14498. All previous steps' forms should be
validated.
"""
+ reached = [False]
that = self
class WizardWithProcessStep(WizardClass):
def process_step(self, request, form, step):
that.assertTrue(hasattr(form, 'cleaned_data'))
+ reached[0] = True
wizard = WizardWithProcessStep([WizardPageOneForm,
WizardPageTwoForm,
@@ -370,6 +372,7 @@ class WizardTests(TestCase):
"hash_0": "7e9cea465f6a10a6fb47fcea65cb9a76350c9a5c",
"wizard_step": "1"}
wizard(DummyRequest(POST=data))
+ self.assertTrue(reached[0])
def test_14576(self):
"""
@@ -400,6 +403,7 @@ class WizardTests(TestCase):
Regression test for ticket #15075. Allow modifying wizard's form_list
in process_step.
"""
+ reached = [False]
that = self
class WizardWithProcessStep(WizardClass):
@@ -408,6 +412,7 @@ class WizardTests(TestCase):
self.form_list[1] = WizardPageTwoAlternativeForm
if step == 1:
that.assertTrue(isinstance(form, WizardPageTwoAlternativeForm))
+ reached[0] = True
wizard = WizardWithProcessStep([WizardPageOneForm,
WizardPageTwoForm,
@@ -417,3 +422,4 @@ class WizardTests(TestCase):
"hash_0": "7e9cea465f6a10a6fb47fcea65cb9a76350c9a5c",
"wizard_step": "1"}
wizard(DummyRequest(POST=data))
+ self.assertTrue(reached[0])