diff options
| author | Jonatas CD <jonatas.cd@gmail.com> | 2017-09-04 21:43:29 +0200 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2017-09-04 15:43:29 -0400 |
| commit | c9b22707b0703db6c6ddaebdd00e2cd33d182e40 (patch) | |
| tree | 5b2c1ec7d38c5934cacdf6de8d5122af147347f8 | |
| parent | 0891503fad458e7dfabc5adbf314f80e78e63f14 (diff) | |
Fixed #28479 -- Doc'd that transaction rollback doesn't revert model state.
| -rw-r--r-- | docs/topics/db/transactions.txt | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/docs/topics/db/transactions.txt b/docs/topics/db/transactions.txt index 7ada3948ce..eb2b02046c 100644 --- a/docs/topics/db/transactions.txt +++ b/docs/topics/db/transactions.txt @@ -176,6 +176,29 @@ Django provides a single API to control database transactions. If you catch exceptions raised by raw SQL queries, Django's behavior is unspecified and database-dependent. + .. admonition:: You may need to manually revert model state when rolling back a transaction. + + The values of a model's fields won't be reverted when a transaction + rollback happens. This could lead to an inconsistent model state unless + you manually restore the original field values. + + For example, given ``MyModel`` with an ``active`` field, this snippet + ensures that the ``if obj.active`` check at the end uses the correct + value if updating ``active`` to ``True`` fails in the transaction:: + + from django.db import DatabaseError, transaction + + obj = MyModel(active=False) + obj.active = True + try: + with transaction.atomic(): + obj.save() + except DatabaseError: + obj.active = False + + if obj.active: + ... + In order to guarantee atomicity, ``atomic`` disables some APIs. Attempting to commit, roll back, or change the autocommit state of the database connection within an ``atomic`` block will raise an exception. |
