summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAymeric Augustin <aymeric.augustin@m4x.org>2011-12-17 15:30:55 +0000
committerAymeric Augustin <aymeric.augustin@m4x.org>2011-12-17 15:30:55 +0000
commitc7534584e8cbb33203675f92e71ec76fb5afd95c (patch)
tree1939f19f5cad62804dae0971933fef7d2219d896
parenta4e516b593a5d4bd81a160b3b1a8cb4b23821b7d (diff)
Explained why UserCreationForm performs custom validation of usernames. Refs #13147.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17225 bcc190cf-cafb-0310-a4f2-bffc1f526a37
-rw-r--r--django/contrib/auth/forms.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/django/contrib/auth/forms.py b/django/contrib/auth/forms.py
index 23185a0ece..57ea108eb4 100644
--- a/django/contrib/auth/forms.py
+++ b/django/contrib/auth/forms.py
@@ -69,6 +69,8 @@ class UserCreationForm(forms.ModelForm):
fields = ("username",)
def clean_username(self):
+ # Since User.username is unique, this check is redundant,
+ # but it sets a nicer error message than the ORM. See #13147.
username = self.cleaned_data["username"]
try:
User.objects.get(username=username)