diff options
| author | Justin Bronn <jbronn@gmail.com> | 2009-04-19 23:31:14 +0000 |
|---|---|---|
| committer | Justin Bronn <jbronn@gmail.com> | 2009-04-19 23:31:14 +0000 |
| commit | bfe36750b157d744c83a6aaea1bf2cb95afdf65d (patch) | |
| tree | 6c1e7f82bcfaa025e94b149398e53277591f7b35 | |
| parent | be11bd40d417331944a2fbf6f2d7b4e2e72680cf (diff) | |
Fixed #10364 -- Correctly identify test spatial database creation errors to the user.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10603 bcc190cf-cafb-0310-a4f2-bffc1f526a37
| -rw-r--r-- | django/contrib/gis/db/backend/postgis/creation.py | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/django/contrib/gis/db/backend/postgis/creation.py b/django/contrib/gis/db/backend/postgis/creation.py index bb7438091d..39306902d6 100644 --- a/django/contrib/gis/db/backend/postgis/creation.py +++ b/django/contrib/gis/db/backend/postgis/creation.py @@ -46,16 +46,19 @@ def _create_with_cursor(db_name, verbosity=1, autoclobber=False): # Trying to create the database first. cursor.execute(create_sql) except Exception, e: - # Drop and recreate, if necessary. - if not autoclobber: - confirm = raw_input("\nIt appears the database, %s, already exists. Type 'yes' to delete it, or 'no' to cancel: " % db_name) - if autoclobber or confirm == 'yes': - if verbosity >= 1: print 'Destroying old spatial database...' - drop_db(db_name) - if verbosity >= 1: print 'Creating new spatial database...' - cursor.execute(create_sql) + if 'already exists' in e.pgerror.lower(): + # Database already exists, drop and recreate if user agrees. + if not autoclobber: + confirm = raw_input("\nIt appears the database, %s, already exists. Type 'yes' to delete it, or 'no' to cancel: " % db_name) + if autoclobber or confirm == 'yes': + if verbosity >= 1: print 'Destroying old spatial database...' + drop_db(db_name) + if verbosity >= 1: print 'Creating new spatial database...' + cursor.execute(create_sql) + else: + raise Exception('Spatial database creation canceled.') else: - raise Exception('Spatial Database Creation canceled.') + raise Exception('Spatial database creation failed: "%s"' % e.pgerror.strip()) created_regex = re.compile(r'^createdb: database creation failed: ERROR: database ".+" already exists') def _create_with_shell(db_name, verbosity=1, autoclobber=False): |