summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRamiro Morales <ramiro@rmorales.net>2014-08-15 16:19:04 -0300
committerRamiro Morales <ramiro@rmorales.net>2014-08-15 16:19:04 -0300
commitb4dce7c37ab7666b023ac791d2c46dad6c8aa637 (patch)
treeb3a90816e3b93b825883dbf59b2523ceeac72ab2
parentd441a9d00629bbaf3f1ef0e4f75f3ce08b76c214 (diff)
Fixed #23298 -- Made makemessages actually ignore specified dirs on Windows.
This was detected by two failures in the i18n.test_extraction of our test suite. Refs #20422, refs #22336
-rw-r--r--django/core/management/commands/makemessages.py13
1 files changed, 11 insertions, 2 deletions
diff --git a/django/core/management/commands/makemessages.py b/django/core/management/commands/makemessages.py
index 335cfab238..0b0d200094 100644
--- a/django/core/management/commands/makemessages.py
+++ b/django/core/management/commands/makemessages.py
@@ -364,8 +364,17 @@ class Command(BaseCommand):
fnmatch.fnmatchcase(path, pattern))
return any(ignore(pattern) for pattern in ignore_patterns)
- dir_suffix = '%s*' % os.sep
- norm_patterns = [p[:-len(dir_suffix)] if p.endswith(dir_suffix) else p for p in self.ignore_patterns]
+ ignore_patterns = [os.path.normcase(p) for p in self.ignore_patterns]
+ dir_suffixes = {'%s*' % path_sep for path_sep in {'/', os.sep}}
+ norm_patterns = []
+ for p in ignore_patterns:
+ for dir_suffix in dir_suffixes:
+ if p.endswith(dir_suffix):
+ norm_patterns.append(p[:-len(dir_suffix)])
+ break
+ else:
+ norm_patterns.append(p)
+
all_files = []
for dirpath, dirnames, filenames in os.walk(root, topdown=True, followlinks=self.symlinks):
for dirname in dirnames[:]: