summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Graham <timograham@gmail.com>2013-05-28 13:35:08 -0400
committerTim Graham <timograham@gmail.com>2013-05-28 13:37:44 -0400
commita2967d5204729771e3716c431ea98f8ee8562d3e (patch)
treeaf1057105ee73c493bc76cc553baacdd342815f4
parent1fdc3d256d5d515bd0b4646ad57f231a2359e0cd (diff)
Fixed #20242 - Added a regression test for prefetch_related.
Issue was fixed by removal of chunked reads from QuerySet iteration in 70679243d1786e03557c28929f9762a119e3ac14. Thanks Simeon Visser for the patch.
-rw-r--r--AUTHORS1
-rw-r--r--tests/prefetch_related/tests.py10
2 files changed, 11 insertions, 0 deletions
diff --git a/AUTHORS b/AUTHORS
index 9c0af6a03a..80f277996b 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -594,6 +594,7 @@ answer newbie questions, and generally made Django that much better:
I.S. van Oostveen <v.oostveen@idca.nl>
viestards.lists@gmail.com
George Vilches <gav@thataddress.com>
+ Simeon Visser <http://simeonvisser.com>
Vlado <vlado@labath.org>
Zachary Voase <zacharyvoase@gmail.com>
Marijn Vriens <marijn@metronomo.cl>
diff --git a/tests/prefetch_related/tests.py b/tests/prefetch_related/tests.py
index 3921153246..2e3fee6be6 100644
--- a/tests/prefetch_related/tests.py
+++ b/tests/prefetch_related/tests.py
@@ -107,6 +107,16 @@ class PrefetchRelatedTests(TestCase):
qs = Book.objects.prefetch_related('first_time_authors')
[b.first_time_authors.exists() for b in qs]
+ def test_in_and_prefetch_related(self):
+ """
+ Regression test for #20242 - QuerySet "in" didn't work the first time
+ when using prefetch_related. This was fixed by the removal of chunked
+ reads from QuerySet iteration in
+ 70679243d1786e03557c28929f9762a119e3ac14.
+ """
+ qs = Book.objects.prefetch_related('first_time_authors')
+ self.assertTrue(qs[0] in qs)
+
def test_clear(self):
"""
Test that we can clear the behavior by calling prefetch_related()