diff options
| author | Hasan Ramezani <hasan.r67@gmail.com> | 2021-03-18 11:04:43 +0100 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2021-03-18 16:30:15 +0100 |
| commit | 9bf5e9418f425666726559c9f1981a516da30aab (patch) | |
| tree | 9007c16942d459dc5adb0674f343d869c606a7b5 | |
| parent | f6713cda89d323565cfdc867c977c3363edcfc3c (diff) | |
Fixed #32556 -- Fixed assertHTMLEqual() to handle empty string as boolean attributes value.
| -rw-r--r-- | django/test/html.py | 4 | ||||
| -rw-r--r-- | tests/test_utils/tests.py | 6 |
2 files changed, 8 insertions, 2 deletions
diff --git a/django/test/html.py b/django/test/html.py index 76ebe0d4f1..b0f63d25d6 100644 --- a/django/test/html.py +++ b/django/test/html.py @@ -64,9 +64,9 @@ class Element: for i in range(len(self.attributes)): attr, value = self.attributes[i] other_attr, other_value = element.attributes[i] - if value is None: + if not value: value = attr - if other_value is None: + if not other_value: other_value = other_attr if attr != other_attr or value != other_value: return False diff --git a/tests/test_utils/tests.py b/tests/test_utils/tests.py index e998573722..137a6e2e1f 100644 --- a/tests/test_utils/tests.py +++ b/tests/test_utils/tests.py @@ -714,6 +714,12 @@ class HTMLEqualTests(SimpleTestCase): with self.subTest(html1): self.assertHTMLEqual(html1, html2) + def test_boolean_attribute(self): + html1 = '<input attr>' + html2 = '<input attr="">' + self.assertHTMLEqual(html1, html2) + self.assertEqual(parse_html(html1), parse_html(html2)) + def test_normalize_refs(self): pairs = [ (''', '''), |
