summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLemuel Sta Ana <lpgstaana@lemuels-mbp.home>2023-09-13 22:37:07 -0400
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2023-09-14 20:35:48 +0200
commit969ecb8236f033d183108fb28849974da188da50 (patch)
treed0ceead2e875fa22b19ea04bc7bd826274ab45d1
parente2a3a896cf0825a2da2347773c79ba7a341fe392 (diff)
Fixed #34834 -- Added role="search" to the admin changelist search form.
-rw-r--r--django/contrib/admin/templates/admin/search_form.html2
-rw-r--r--tests/admin_changelist/tests.py10
2 files changed, 11 insertions, 1 deletions
diff --git a/django/contrib/admin/templates/admin/search_form.html b/django/contrib/admin/templates/admin/search_form.html
index e3a0ee540b..447b8039af 100644
--- a/django/contrib/admin/templates/admin/search_form.html
+++ b/django/contrib/admin/templates/admin/search_form.html
@@ -1,6 +1,6 @@
{% load i18n static %}
{% if cl.search_fields %}
-<div id="toolbar"><form id="changelist-search" method="get">
+<div id="toolbar"><form id="changelist-search" method="get" role="search">
<div><!-- DIV needed for valid HTML -->
<label for="searchbar"><img src="{% static "admin/img/search.svg" %}" alt="Search"></label>
<input type="text" size="40" name="{{ search_var }}" value="{{ cl.query }}" id="searchbar"{% if cl.search_help_text %} aria-describedby="searchbar_helptext"{% endif %}>
diff --git a/tests/admin_changelist/tests.py b/tests/admin_changelist/tests.py
index a926f9d826..4caefdb9e4 100644
--- a/tests/admin_changelist/tests.py
+++ b/tests/admin_changelist/tests.py
@@ -1585,6 +1585,16 @@ class ChangeListTests(TestCase):
'aria-describedby="searchbar_helptext">',
)
+ def test_search_role(self):
+ m = BandAdmin(Band, custom_site)
+ m.search_fields = ["name"]
+ request = self._mocked_authenticated_request("/band/", self.superuser)
+ response = m.changelist_view(request)
+ self.assertContains(
+ response,
+ '<form id="changelist-search" method="get" role="search">',
+ )
+
def test_search_bar_total_link_preserves_options(self):
self.client.force_login(self.superuser)
url = reverse("admin:auth_user_changelist")