diff options
| author | Tim Graham <timograham@gmail.com> | 2017-04-15 09:21:35 -0400 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2017-04-15 09:21:54 -0400 |
| commit | 91bbe7b1c1da16d51ec35a307762526c026b093a (patch) | |
| tree | 285315ee3dad76a9c61e95ffd3bad3420e932b91 | |
| parent | 9a93c1a394f4bab9f91f29005d9a042907e13de8 (diff) | |
[1.11.x] Fixed #28079 -- Restored "No POST data" (rather than an empty table) in HTML debug page.
Regression in 7b6dccc82fa5b03cf431742c0655e5ac954e228e
Backport of 8c6a3062dda7b51c3f545e625f529ce5c183040d from master
| -rw-r--r-- | django/views/debug.py | 2 | ||||
| -rw-r--r-- | docs/releases/1.11.1.txt | 3 | ||||
| -rw-r--r-- | tests/view_tests/tests/test_debug.py | 1 |
3 files changed, 5 insertions, 1 deletions
diff --git a/django/views/debug.py b/django/views/debug.py index af03882e77..57dbff2259 100644 --- a/django/views/debug.py +++ b/django/views/debug.py @@ -297,7 +297,7 @@ class ExceptionReporter(object): 'frames': frames, 'request': self.request, 'user_str': user_str, - 'filtered_POST_items': self.filter.get_post_parameters(self.request).items(), + 'filtered_POST_items': list(self.filter.get_post_parameters(self.request).items()), 'settings': get_safe_settings(), 'sys_executable': sys.executable, 'sys_version_info': '%d.%d.%d' % sys.version_info[0:3], diff --git a/docs/releases/1.11.1.txt b/docs/releases/1.11.1.txt index 066127d5e4..e7f2638881 100644 --- a/docs/releases/1.11.1.txt +++ b/docs/releases/1.11.1.txt @@ -21,3 +21,6 @@ Bugfixes * Fixed ``QuerySet.filter()`` crash when it references the name of a ``OneToOneField`` primary key (:ticket:`28047`). + +* Fixed empty POST data table appearing instead of "No POST data" in HTML debug + page (:ticket:`28079`). diff --git a/tests/view_tests/tests/test_debug.py b/tests/view_tests/tests/test_debug.py index 24fa593621..52789a392c 100644 --- a/tests/view_tests/tests/test_debug.py +++ b/tests/view_tests/tests/test_debug.py @@ -304,6 +304,7 @@ class ExceptionReporterTests(SimpleTestCase): self.assertIn('<h2>Traceback ', html) self.assertIn('<h2>Request information</h2>', html) self.assertNotIn('<p>Request data not supplied</p>', html) + self.assertIn('<p>No POST data</p>', html) def test_no_request(self): "An exception report can be generated without request" |