diff options
| author | Aymeric Augustin <aymeric.augustin@m4x.org> | 2022-04-16 18:35:30 +0200 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2022-04-19 06:25:38 +0200 |
| commit | 903702dfb1461cbb4ab93f841651e6882a72d337 (patch) | |
| tree | 56800f1f601494e25e3f124d7e05c855033b7752 | |
| parent | 5591a72571b8a07c5e3d87dcfe08310bb7611d15 (diff) | |
Removed unnecessary default argument from GET.get() call in LoginView.get_redirect_url().
The default argument is unnecessary because
url_has_allowed_host_and_scheme() returns False when its first argument
is "" or None, so get_redirect_url() still returns "".
This also aligns LoginView.get_redirect_url() and LogoutView.get_next_page().
| -rw-r--r-- | django/contrib/auth/views.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/django/contrib/auth/views.py b/django/contrib/auth/views.py index 5de3989ffc..60e6611b98 100644 --- a/django/contrib/auth/views.py +++ b/django/contrib/auth/views.py @@ -74,7 +74,7 @@ class LoginView(SuccessURLAllowedHostsMixin, FormView): def get_redirect_url(self): """Return the user-originating redirect URL if it's safe.""" redirect_to = self.request.POST.get( - self.redirect_field_name, self.request.GET.get(self.redirect_field_name, "") + self.redirect_field_name, self.request.GET.get(self.redirect_field_name) ) url_is_safe = url_has_allowed_host_and_scheme( url=redirect_to, |