summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdam Johnson <me@adamj.eu>2021-01-19 06:04:53 +0000
committerGitHub <noreply@github.com>2021-01-19 07:04:53 +0100
commit8c7ff7b8cff4a62423512efc3c4fe7955edfeed5 (patch)
treed886d6d28739187a0819fc3035a8ac6b7e55d23a
parent6b01511f04da573d450cdffab471538e70aec01e (diff)
Removed unreachable SystemExit check.
This check dates back to Python <2.5, before Python introduced BaseException to prevent exactly unwarranted catching of SystemExit (and others). response_for_exception() is only called under `except Exception` or `except Http404` so it's now impossible for a SystemExit instance to reach the branch.
-rw-r--r--django/core/handlers/exception.py4
1 files changed, 0 insertions, 4 deletions
diff --git a/django/core/handlers/exception.py b/django/core/handlers/exception.py
index 3005a5eccb..87a6650542 100644
--- a/django/core/handlers/exception.py
+++ b/django/core/handlers/exception.py
@@ -105,10 +105,6 @@ def response_for_exception(request, exc):
else:
response = get_exception_response(request, get_resolver(get_urlconf()), 400, exc)
- elif isinstance(exc, SystemExit):
- # Allow sys.exit() to actually exit. See tickets #1023 and #4701
- raise
-
else:
signals.got_request_exception.send(sender=None, request=request)
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())