summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDiederik van der Boor <vdboor@edoburu.nl>2020-02-23 22:04:18 +0100
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2020-02-24 13:28:51 +0100
commit84e35f4679622bf6cf7c1763bee3ce9af9c892ff (patch)
treee9061a35f428960fbcad65d7e5dfb0c9205d80db
parent975eb4203696e623e91df32a21df9ba4c89e90bc (diff)
Fixed #31292 -- Fixed django.contrib.gis.gdal.gdal_full_version() crash.
-rw-r--r--django/contrib/gis/gdal/libgdal.py2
-rw-r--r--tests/gis_tests/gdal_tests/tests.py9
2 files changed, 9 insertions, 2 deletions
diff --git a/django/contrib/gis/gdal/libgdal.py b/django/contrib/gis/gdal/libgdal.py
index 5bdb362db7..f825abe8ba 100644
--- a/django/contrib/gis/gdal/libgdal.py
+++ b/django/contrib/gis/gdal/libgdal.py
@@ -80,7 +80,7 @@ def gdal_version():
def gdal_full_version():
"Return the full GDAL version information."
- return _version_info('')
+ return _version_info(b'')
version_regex = _lazy_re_compile(r'^(?P<major>\d+)\.(?P<minor>\d+)(\.(?P<subminor>\d+))?')
diff --git a/tests/gis_tests/gdal_tests/tests.py b/tests/gis_tests/gdal_tests/tests.py
index a1847cd677..607753271f 100644
--- a/tests/gis_tests/gdal_tests/tests.py
+++ b/tests/gis_tests/gdal_tests/tests.py
@@ -1,6 +1,8 @@
import unittest
-from django.contrib.gis.gdal import GDAL_VERSION, gdal_version
+from django.contrib.gis.gdal import (
+ GDAL_VERSION, gdal_full_version, gdal_version,
+)
class GDALTest(unittest.TestCase):
@@ -9,3 +11,8 @@ class GDALTest(unittest.TestCase):
self.assertEqual(gdal_version(), ('%s.%s.%s' % GDAL_VERSION).encode())
else:
self.assertIn(b'.', gdal_version())
+
+ def test_gdal_full_version(self):
+ full_version = gdal_full_version()
+ self.assertIn(gdal_version(), full_version)
+ self.assertTrue(full_version.startswith(b'GDAL'))