summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Walls <jacobtylerwalls@gmail.com>2025-01-22 22:21:09 -0500
committerSarah Boyce <42296566+sarahboyce@users.noreply.github.com>2025-01-28 10:19:43 +0000
commit72ff18d41cfb004ae180bdf87fd8bad93041c691 (patch)
treeb4b23ff1178ca8bc99a0ef36781086714811a855
parentd9af197801376fae178761cac12d57178a738cf4 (diff)
Fixed #36120 -- Raised FieldError when targeting a composite primary key field with QuerySet.update().
-rw-r--r--django/db/models/sql/subqueries.py4
-rw-r--r--tests/composite_pk/test_update.py7
2 files changed, 11 insertions, 0 deletions
diff --git a/django/db/models/sql/subqueries.py b/django/db/models/sql/subqueries.py
index b2810c8413..9cb971b38f 100644
--- a/django/db/models/sql/subqueries.py
+++ b/django/db/models/sql/subqueries.py
@@ -90,6 +90,10 @@ class UpdateQuery(Query):
not (field.auto_created and not field.concrete) or not field.concrete
)
model = field.model._meta.concrete_model
+ if field.name == "pk" and model._meta.is_composite_pk:
+ raise FieldError(
+ "Composite primary key fields must be updated individually."
+ )
if not direct or (field.is_relation and field.many_to_many):
raise FieldError(
"Cannot update model field %r (only non-relations and "
diff --git a/tests/composite_pk/test_update.py b/tests/composite_pk/test_update.py
index ec770230fc..5bc53f1fe1 100644
--- a/tests/composite_pk/test_update.py
+++ b/tests/composite_pk/test_update.py
@@ -1,3 +1,4 @@
+from django.core.exceptions import FieldError
from django.db import connection
from django.test import TestCase
@@ -175,3 +176,9 @@ class CompositePKUpdateTests(TestCase):
with self.assertRaisesMessage(ValueError, msg):
Comment.objects.update(user=User())
+
+ def test_cant_update_pk_field(self):
+ qs = Comment.objects.filter(user__email=self.user_1.email)
+ msg = "Composite primary key fields must be updated individually."
+ with self.assertRaisesMessage(FieldError, msg):
+ qs.update(pk=(1, 10))