summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBaptiste Mispelon <bmispelon@gmail.com>2014-08-03 12:59:21 +0200
committerBaptiste Mispelon <bmispelon@gmail.com>2014-08-03 13:02:31 +0200
commit72f1eb48df335c110f39d56f7978d95896a56bb8 (patch)
treeeebfa3fda53980bd60c7cdc59733beb556f910e8
parenta9fa3d466771b1f5d05fcf55f94abfaf7b0c3258 (diff)
Fixed #23156 -- Added missing BinaryField.deconstruct() method.
-rw-r--r--django/db/models/fields/__init__.py5
-rw-r--r--tests/field_deconstruction/tests.py7
2 files changed, 12 insertions, 0 deletions
diff --git a/django/db/models/fields/__init__.py b/django/db/models/fields/__init__.py
index 3d8a5b79ad..a0f72a7fd6 100644
--- a/django/db/models/fields/__init__.py
+++ b/django/db/models/fields/__init__.py
@@ -2178,6 +2178,11 @@ class BinaryField(Field):
if self.max_length is not None:
self.validators.append(validators.MaxLengthValidator(self.max_length))
+ def deconstruct(self):
+ name, path, args, kwargs = super(BinaryField, self).deconstruct()
+ del kwargs['editable']
+ return name, path, args, kwargs
+
def get_internal_type(self):
return "BinaryField"
diff --git a/tests/field_deconstruction/tests.py b/tests/field_deconstruction/tests.py
index 5a424eea3c..be73f8b19e 100644
--- a/tests/field_deconstruction/tests.py
+++ b/tests/field_deconstruction/tests.py
@@ -347,3 +347,10 @@ class FieldDeconstructionTests(TestCase):
self.assertEqual(path, "django.db.models.URLField")
self.assertEqual(args, [])
self.assertEqual(kwargs, {"max_length": 231})
+
+ def test_binary_field(self):
+ field = models.BinaryField()
+ name, path, args, kwargs = field.deconstruct()
+ self.assertEqual(path, "django.db.models.BinaryField")
+ self.assertEqual(args, [])
+ self.assertEqual(kwargs, {})