summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Cramer <dcramer@gmail.com>2013-01-11 14:58:36 -0800
committerDavid Cramer <dcramer@gmail.com>2013-01-14 13:15:47 -0800
commit6045efa029dcae58ec6aab20bdcb0dc325851048 (patch)
treeb871e981d9c48bce1758a53def79b922c964ee54
parentd53e3b15eee6cb89e3a4651b0f89b01fd30360d7 (diff)
Move signal disconnect into finally block
-rw-r--r--tests/modeltests/delete/tests.py10
1 files changed, 6 insertions, 4 deletions
diff --git a/tests/modeltests/delete/tests.py b/tests/modeltests/delete/tests.py
index 5d7b7a0b33..99981df018 100644
--- a/tests/modeltests/delete/tests.py
+++ b/tests/modeltests/delete/tests.py
@@ -233,13 +233,15 @@ class DeletionTests(TestCase):
def log_post_delete(instance, **kwargs):
self.assertTrue(R.objects.filter(pk=instance.r_id))
- models.signals.post_delete.connect(log_post_delete, sender=S)
-
r = R.objects.create(pk=1)
S.objects.create(pk=1, r=r)
- r.delete()
- models.signals.post_delete.disconnect(log_post_delete)
+ models.signals.post_delete.connect(log_post_delete, sender=S)
+
+ try:
+ r.delete()
+ finally:
+ models.signals.post_delete.disconnect(log_post_delete)
@skipUnlessDBFeature("can_defer_constraint_checks")
def test_can_defer_constraint_checks(self):