summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeryn Knight <keryn@kerynknight.com>2021-07-18 14:06:30 +0100
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2021-07-19 11:42:20 +0200
commit59942a66ceb79868cb91844df3a72a24c63e39fa (patch)
tree6a4be25a7d54e1a31bb43d20701a1c1c64d83a64
parent37ec8721df493413d5ea5266b6faead9b8f520a9 (diff)
Fixed #32941 -- Removed get_format_modules()'s unused reverse argument.
Unused since 0d8b523422fda71baa10807d5aebefd34bad7962.
-rw-r--r--django/utils/formats.py7
-rw-r--r--tests/i18n/tests.py13
2 files changed, 5 insertions, 15 deletions
diff --git a/django/utils/formats.py b/django/utils/formats.py
index d6eccf6b68..cffbb34398 100644
--- a/django/utils/formats.py
+++ b/django/utils/formats.py
@@ -86,16 +86,13 @@ def iter_format_modules(lang, format_module_path=None):
pass
-def get_format_modules(lang=None, reverse=False):
+def get_format_modules(lang=None):
"""Return a list of the format modules found."""
if lang is None:
lang = get_language()
if lang not in _format_modules_cache:
_format_modules_cache[lang] = list(iter_format_modules(lang, settings.FORMAT_MODULE_PATH))
- modules = _format_modules_cache[lang]
- if reverse:
- return list(reversed(modules))
- return modules
+ return _format_modules_cache[lang]
def get_format(format_type, lang=None, use_l10n=None):
diff --git a/tests/i18n/tests.py b/tests/i18n/tests.py
index 7705df738c..eba4a8595c 100644
--- a/tests/i18n/tests.py
+++ b/tests/i18n/tests.py
@@ -23,9 +23,9 @@ from django.test import (
)
from django.utils import translation
from django.utils.formats import (
- date_format, get_format, get_format_modules, iter_format_modules, localize,
- localize_input, reset_format_cache, sanitize_separators,
- sanitize_strftime_format, time_format,
+ date_format, get_format, iter_format_modules, localize, localize_input,
+ reset_format_cache, sanitize_separators, sanitize_strftime_format,
+ time_format,
)
from django.utils.numberformat import format as nformat
from django.utils.safestring import SafeString, mark_safe
@@ -1196,13 +1196,6 @@ class FormattingTests(SimpleTestCase):
with translation.override('de', deactivate=True):
self.assertEqual('.', get_format('DECIMAL_SEPARATOR', lang='en'))
- def test_get_format_modules_stability(self):
- with self.settings(FORMAT_MODULE_PATH='i18n.other.locale'):
- with translation.override('de', deactivate=True):
- old = "%r" % get_format_modules(reverse=True)
- new = "%r" % get_format_modules(reverse=True) # second try
- self.assertEqual(new, old, 'Value returned by get_formats_modules() must be preserved between calls.')
-
def test_localize_templatetag_and_filter(self):
"""
Test the {% localize %} templatetag and the localize/unlocalize filters.