diff options
| author | Russell Keith-Magee <russell@keith-magee.com> | 2006-12-20 09:59:03 +0000 |
|---|---|---|
| committer | Russell Keith-Magee <russell@keith-magee.com> | 2006-12-20 09:59:03 +0000 |
| commit | 2d6095ea5e0d7c7cd8be16b02d17b5018642e3c2 (patch) | |
| tree | 249f6236c5a0609f226775a95b0463f1a3544850 | |
| parent | 069a8858baa6a6b687e67312ffdbcdfc55cee4b7 (diff) | |
Fixed #3142 -- Optimized the assignment of m2m and m2o relation sets. Thanks, (and well spotted!) mitakummaa@gmail.com.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4231 bcc190cf-cafb-0310-a4f2-bffc1f526a37
| -rw-r--r-- | AUTHORS | 1 | ||||
| -rw-r--r-- | django/db/models/fields/related.py | 9 |
2 files changed, 4 insertions, 6 deletions
@@ -123,6 +123,7 @@ answer newbie questions, and generally made Django that much better: Jason McBrayer <http://www.carcosa.net/jason/> mccutchen@gmail.com michael.mcewan@gmail.com + mitakummaa@gmail.com mmarshall Eric Moritz <http://eric.themoritzfamily.com/> Robin Munn <http://www.geekforgod.com/> diff --git a/django/db/models/fields/related.py b/django/db/models/fields/related.py index 6c9d7f258f..60a5b9b7b0 100644 --- a/django/db/models/fields/related.py +++ b/django/db/models/fields/related.py @@ -256,8 +256,7 @@ class ForeignRelatedObjectsDescriptor(object): # Otherwise, just move the named objects into the set. if self.related.field.null: manager.clear() - for obj in value: - manager.add(obj) + manager.add(*value) def create_many_related_manager(superclass): """Creates a manager that subclasses 'superclass' (which is a Manager) @@ -405,8 +404,7 @@ class ManyRelatedObjectsDescriptor(object): manager = self.__get__(instance) manager.clear() - for obj in value: - manager.add(obj) + manager.add(*value) class ReverseManyRelatedObjectsDescriptor(object): # This class provides the functionality that makes the related-object @@ -447,8 +445,7 @@ class ReverseManyRelatedObjectsDescriptor(object): manager = self.__get__(instance) manager.clear() - for obj in value: - manager.add(obj) + manager.add(*value) class ForeignKey(RelatedField, Field): empty_strings_allowed = False |