diff options
| author | Nina Menezes <77671865+nmenezes0@users.noreply.github.com> | 2023-06-02 11:32:18 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-02 12:32:18 +0200 |
| commit | 27fed08e5ff597c813de25b6e89dc300a1f4231b (patch) | |
| tree | e434cfb119ef92ea3d965992413337da0a39f832 | |
| parent | 2cf76f2d5d1aa16acfadaf53db3d30128a34b088 (diff) | |
Fixed #34618 -- Added icon descriptions in "Recent Actions" on the admin index.
| -rw-r--r-- | django/contrib/admin/static/admin/css/base.css | 13 | ||||
| -rw-r--r-- | django/contrib/admin/static/admin/css/dark_mode.css | 13 | ||||
| -rw-r--r-- | django/contrib/admin/templates/admin/index.html | 1 | ||||
| -rw-r--r-- | tests/admin_views/tests.py | 24 |
4 files changed, 38 insertions, 13 deletions
diff --git a/django/contrib/admin/static/admin/css/base.css b/django/contrib/admin/static/admin/css/base.css index ec2c8e34d0..0bde69d013 100644 --- a/django/contrib/admin/static/admin/css/base.css +++ b/django/contrib/admin/static/admin/css/base.css @@ -1139,3 +1139,16 @@ a.deletelink:focus, a.deletelink:hover { .base-svgs { display: none; } + +.visually-hidden { + position: absolute; + width: 1px; + height: 1px; + padding: 0; + overflow: hidden; + clip: rect(0,0,0,0); + white-space: nowrap; + border: 0; + color: var(--body-fg); + background-color: var(--body-bg); +} diff --git a/django/contrib/admin/static/admin/css/dark_mode.css b/django/contrib/admin/static/admin/css/dark_mode.css index 6d08233aae..c49b6bc26f 100644 --- a/django/contrib/admin/static/admin/css/dark_mode.css +++ b/django/contrib/admin/static/admin/css/dark_mode.css @@ -122,16 +122,3 @@ html[data-theme="dark"] .theme-toggle svg.theme-icon-when-dark { html[data-theme="light"] .theme-toggle svg.theme-icon-when-light { display: block; } - -.visually-hidden { - position: absolute; - width: 1px; - height: 1px; - padding: 0; - overflow: hidden; - clip: rect(0,0,0,0); - white-space: nowrap; - border: 0; - color: var(--body-fg); - background-color: var(--body-bg); -} diff --git a/django/contrib/admin/templates/admin/index.html b/django/contrib/admin/templates/admin/index.html index af4f26dec5..899727a4ba 100644 --- a/django/contrib/admin/templates/admin/index.html +++ b/django/contrib/admin/templates/admin/index.html @@ -30,6 +30,7 @@ <ul class="actionlist"> {% for entry in admin_log %} <li class="{% if entry.is_addition %}addlink{% endif %}{% if entry.is_change %}changelink{% endif %}{% if entry.is_deletion %}deletelink{% endif %}"> + <span class="visually-hidden">{% if entry.is_addition %}{% translate 'Added:' %}{% elif entry.is_change %}{% translate 'Changed:' %}{% elif entry.is_deletion %}{% translate 'Deleted:' %}{% endif %}</span> {% if entry.is_deletion or not entry.get_admin_url %} {{ entry.object_repr }} {% else %} diff --git a/tests/admin_views/tests.py b/tests/admin_views/tests.py index 4db06ca84a..bbc6f731f7 100644 --- a/tests/admin_views/tests.py +++ b/tests/admin_views/tests.py @@ -3704,6 +3704,22 @@ class AdminViewStringPrimaryKeyTest(TestCase): 2, change_message="Changed something", ) + LogEntry.objects.log_action( + user_pk, + content_type_pk, + cls.pk, + cls.pk, + 1, + change_message="Added something", + ) + LogEntry.objects.log_action( + user_pk, + content_type_pk, + cls.pk, + cls.pk, + 3, + change_message="Deleted something", + ) def setUp(self): self.client.force_login(self.superuser) @@ -3762,6 +3778,14 @@ class AdminViewStringPrimaryKeyTest(TestCase): should_contain = """<a href="%s">%s</a>""" % (escape(link), escape(self.pk)) self.assertContains(response, should_contain) + def test_recentactions_description(self): + response = self.client.get(reverse("admin:index")) + for operation in ["Added", "Changed", "Deleted"]: + with self.subTest(operation): + self.assertContains( + response, f'<span class="visually-hidden">{operation}:' + ) + def test_deleteconfirmation_link(self): """ " The link from the delete confirmation page referring back to the |
