diff options
| author | Aman Pandey <aman2001mi@gmail.com> | 2023-11-27 23:21:33 +0530 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2023-11-28 05:46:04 +0100 |
| commit | 0fcd72bc48eade21ce9202d7a71692f9b5a42bd2 (patch) | |
| tree | 2a8854578e820198143d9ad4d8c60947f06551c6 | |
| parent | 729266c6f29c7a0677b24926a86a767ef3078b26 (diff) | |
Fixed #34633 -- Made create() method of reverse many-to-one managers clear prefetch_related() cache.
| -rw-r--r-- | django/db/models/fields/related_descriptors.py | 1 | ||||
| -rw-r--r-- | docs/ref/models/querysets.txt | 1 | ||||
| -rw-r--r-- | tests/many_to_one/tests.py | 8 |
3 files changed, 10 insertions, 0 deletions
diff --git a/django/db/models/fields/related_descriptors.py b/django/db/models/fields/related_descriptors.py index 46a5823647..f5a81ab49c 100644 --- a/django/db/models/fields/related_descriptors.py +++ b/django/db/models/fields/related_descriptors.py @@ -840,6 +840,7 @@ def create_reverse_many_to_one_manager(superclass, rel): def create(self, **kwargs): self._check_fk_val() + self._remove_prefetched_objects() kwargs[self.field.name] = self.instance db = router.db_for_write(self.model, instance=self.instance) return super(RelatedManager, self.db_manager(db)).create(**kwargs) diff --git a/docs/ref/models/querysets.txt b/docs/ref/models/querysets.txt index 9f2a417881..b9f263f709 100644 --- a/docs/ref/models/querysets.txt +++ b/docs/ref/models/querysets.txt @@ -1259,6 +1259,7 @@ database. Also, if you call the database-altering methods :meth:`~django.db.models.fields.related.RelatedManager.add`, + :meth:`~django.db.models.fields.related.RelatedManager.create`, :meth:`~django.db.models.fields.related.RelatedManager.remove`, :meth:`~django.db.models.fields.related.RelatedManager.clear` or :meth:`~django.db.models.fields.related.RelatedManager.set`, on diff --git a/tests/many_to_one/tests.py b/tests/many_to_one/tests.py index b07972ec31..ac5b35e055 100644 --- a/tests/many_to_one/tests.py +++ b/tests/many_to_one/tests.py @@ -800,6 +800,14 @@ class ManyToOneTests(TestCase): # refs #21563 self.assertFalse(hasattr(Article(), "reporter")) + def test_create_after_prefetch(self): + c = City.objects.create(name="Musical City") + d1 = District.objects.create(name="Ladida", city=c) + city = City.objects.prefetch_related("districts").get(id=c.id) + self.assertSequenceEqual(city.districts.all(), [d1]) + d2 = city.districts.create(name="Goa") + self.assertSequenceEqual(city.districts.all(), [d1, d2]) + def test_clear_after_prefetch(self): c = City.objects.create(name="Musical City") d = District.objects.create(name="Ladida", city=c) |